Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build_type key exists check #20671

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

tatsuya-ogawa
Copy link
Contributor

@tatsuya-ogawa tatsuya-ogawa commented Aug 24, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccAWSCodeBuildWebhook_BuildType'                                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildWebhook_BuildType -timeout 180m
=== RUN   TestAccAWSCodeBuildWebhook_BuildType
=== PAUSE TestAccAWSCodeBuildWebhook_BuildType
=== CONT  TestAccAWSCodeBuildWebhook_BuildType
--- PASS: TestAccAWSCodeBuildWebhook_BuildType (96.21s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       97.836s

Related #20480 (comment)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR. labels Aug 24, 2021
@tatsuya-ogawa tatsuya-ogawa changed the title fix build_type default value fix build_type key exists check Aug 24, 2021
@tatsuya-ogawa tatsuya-ogawa marked this pull request as draft August 24, 2021 09:51
@tatsuya-ogawa tatsuya-ogawa marked this pull request as ready for review August 24, 2021 10:23
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Aug 24, 2021
@breathingdust breathingdust added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 26, 2021
@ewbankkit ewbankkit self-assigned this Aug 26, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_CODEBUILD_GITHUB_SOURCE_LOCATION=... make testacc TESTARGS='-run=TestAccAWSCodeBuildWebhook_GitHub\|TestAccAWSCodeBuildWebhook_BuildType'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildWebhook_GitHub\|TestAccAWSCodeBuildWebhook_BuildType -timeout 180m
=== RUN   TestAccAWSCodeBuildWebhook_GitHub
=== PAUSE TestAccAWSCodeBuildWebhook_GitHub
=== RUN   TestAccAWSCodeBuildWebhook_BuildType
=== PAUSE TestAccAWSCodeBuildWebhook_BuildType
=== CONT  TestAccAWSCodeBuildWebhook_GitHub
=== CONT  TestAccAWSCodeBuildWebhook_BuildType
--- PASS: TestAccAWSCodeBuildWebhook_GitHub (28.65s)
--- PASS: TestAccAWSCodeBuildWebhook_BuildType (49.20s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       52.356s

@ewbankkit
Copy link
Contributor

@tatsuya-ogawa Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 073ba96 into hashicorp:main Aug 26, 2021
@github-actions github-actions bot added this to the v3.56.0 milestone Aug 26, 2021
@tatsuya-ogawa tatsuya-ogawa deleted the b-codebuild-webhook-buildtype branch August 29, 2021 16:37
@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants