-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use configuration_set name instead of arn in aws_pinpoint_email_channel_resource #20691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ubrandrew 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAWSPinpointEmailChannel_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSPinpointEmailChannel_ -timeout 180m
=== RUN TestAccAWSPinpointEmailChannel_basic
=== PAUSE TestAccAWSPinpointEmailChannel_basic
=== RUN TestAccAWSPinpointEmailChannel_configurationSet
=== PAUSE TestAccAWSPinpointEmailChannel_configurationSet
=== RUN TestAccAWSPinpointEmailChannel_noRole
=== PAUSE TestAccAWSPinpointEmailChannel_noRole
=== RUN TestAccAWSPinpointEmailChannel_disappears
=== PAUSE TestAccAWSPinpointEmailChannel_disappears
=== CONT TestAccAWSPinpointEmailChannel_basic
=== CONT TestAccAWSPinpointEmailChannel_disappears
=== CONT TestAccAWSPinpointEmailChannel_configurationSet
=== CONT TestAccAWSPinpointEmailChannel_noRole
--- PASS: TestAccAWSPinpointEmailChannel_disappears (18.08s)
--- PASS: TestAccAWSPinpointEmailChannel_noRole (20.60s)
--- PASS: TestAccAWSPinpointEmailChannel_configurationSet (20.86s)
--- PASS: TestAccAWSPinpointEmailChannel_basic (30.96s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 34.791s
@ubrandrew Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20295
Output from acceptance testing: