Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use configuration_set name instead of arn in aws_pinpoint_email_channel_resource #20691

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

ubrandrew
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20295

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSPinpointEmailChannel_'                                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSPinpointEmailChannel_ -timeout 180m
=== RUN   TestAccAWSPinpointEmailChannel_basic
=== PAUSE TestAccAWSPinpointEmailChannel_basic
=== RUN   TestAccAWSPinpointEmailChannel_configurationSet
=== PAUSE TestAccAWSPinpointEmailChannel_configurationSet
=== RUN   TestAccAWSPinpointEmailChannel_noRole
=== PAUSE TestAccAWSPinpointEmailChannel_noRole
=== RUN   TestAccAWSPinpointEmailChannel_disappears
=== PAUSE TestAccAWSPinpointEmailChannel_disappears
=== CONT  TestAccAWSPinpointEmailChannel_basic
=== CONT  TestAccAWSPinpointEmailChannel_noRole
=== CONT  TestAccAWSPinpointEmailChannel_configurationSet
=== CONT  TestAccAWSPinpointEmailChannel_disappears
--- PASS: TestAccAWSPinpointEmailChannel_disappears (11.08s)
--- PASS: TestAccAWSPinpointEmailChannel_noRole (12.19s)
--- PASS: TestAccAWSPinpointEmailChannel_configurationSet (12.54s)
--- PASS: TestAccAWSPinpointEmailChannel_basic (19.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       19.560s

@github-actions github-actions bot added service/pinpoint Issues and PRs that pertain to the pinpoint service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Aug 26, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ubrandrew 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ubrandrew ubrandrew marked this pull request as ready for review August 26, 2021 14:18
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Aug 26, 2021
@ewbankkit
Copy link
Contributor

API Reference.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSPinpointEmailChannel_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSPinpointEmailChannel_ -timeout 180m
=== RUN   TestAccAWSPinpointEmailChannel_basic
=== PAUSE TestAccAWSPinpointEmailChannel_basic
=== RUN   TestAccAWSPinpointEmailChannel_configurationSet
=== PAUSE TestAccAWSPinpointEmailChannel_configurationSet
=== RUN   TestAccAWSPinpointEmailChannel_noRole
=== PAUSE TestAccAWSPinpointEmailChannel_noRole
=== RUN   TestAccAWSPinpointEmailChannel_disappears
=== PAUSE TestAccAWSPinpointEmailChannel_disappears
=== CONT  TestAccAWSPinpointEmailChannel_basic
=== CONT  TestAccAWSPinpointEmailChannel_disappears
=== CONT  TestAccAWSPinpointEmailChannel_configurationSet
=== CONT  TestAccAWSPinpointEmailChannel_noRole
--- PASS: TestAccAWSPinpointEmailChannel_disappears (18.08s)
--- PASS: TestAccAWSPinpointEmailChannel_noRole (20.60s)
--- PASS: TestAccAWSPinpointEmailChannel_configurationSet (20.86s)
--- PASS: TestAccAWSPinpointEmailChannel_basic (30.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.791s

@ewbankkit
Copy link
Contributor

@ubrandrew Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7481af6 into hashicorp:main Aug 30, 2021
@github-actions github-actions bot added this to the v3.57.0 milestone Aug 30, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/pinpoint Issues and PRs that pertain to the pinpoint service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_pinpoint_email_channel configuration set should use name instead of ARN
3 participants