Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default value 'missing' for 'treat_missing_data' #21363

Merged
merged 3 commits into from
Oct 19, 2021
Merged

default value 'missing' for 'treat_missing_data' #21363

merged 3 commits into from
Oct 19, 2021

Conversation

nyamada00
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #8854

Output from acceptance testing:

$ make testacc PKG_NAME=internal/service/cloudwatch TEST=./aws TESTARGS='-run=TestAccCloudWatchMetricAlarm'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch -v -count 1 -parallel 20 -run=TestAccCloudWatchMetricAlarm -timeout 180m
=== RUN   TestAccCloudWatchMetricAlarm_basic
=== PAUSE TestAccCloudWatchMetricAlarm_basic
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== RUN   TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== PAUSE TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== RUN   TestAccCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccCloudWatchMetricAlarm_treatMissingData
=== RUN   TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN   TestAccCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_extendedStatistic
=== RUN   TestAccCloudWatchMetricAlarm_expression
=== PAUSE TestAccCloudWatchMetricAlarm_expression
=== RUN   TestAccCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_missingStatistic
=== RUN   TestAccCloudWatchMetricAlarm_tags
=== PAUSE TestAccCloudWatchMetricAlarm_tags
=== RUN   TestAccCloudWatchMetricAlarm_disappears
=== PAUSE TestAccCloudWatchMetricAlarm_disappears
=== CONT  TestAccCloudWatchMetricAlarm_basic
=== CONT  TestAccCloudWatchMetricAlarm_extendedStatistic
=== CONT  TestAccCloudWatchMetricAlarm_disappears
=== CONT  TestAccCloudWatchMetricAlarm_tags
=== CONT  TestAccCloudWatchMetricAlarm_missingStatistic
=== CONT  TestAccCloudWatchMetricAlarm_expression
=== CONT  TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== CONT  TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT  TestAccCloudWatchMetricAlarm_treatMissingData
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (20.69s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (35.24s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (37.87s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (40.05s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (44.91s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (45.58s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (48.96s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (59.95s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (87.18s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (89.07s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (161.39s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (299.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch 299.253s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Oct 19, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nyamada00 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 19, 2021
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Oct 19, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccCloudWatchMetricAlarm_' PKG_NAME=internal/service/cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch -v -count 1 -parallel 20 -run=TestAccCloudWatchMetricAlarm_ -timeout 180m
=== RUN   TestAccCloudWatchMetricAlarm_basic
=== PAUSE TestAccCloudWatchMetricAlarm_basic
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== RUN   TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== PAUSE TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== RUN   TestAccCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccCloudWatchMetricAlarm_treatMissingData
=== RUN   TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN   TestAccCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_extendedStatistic
=== RUN   TestAccCloudWatchMetricAlarm_expression
=== PAUSE TestAccCloudWatchMetricAlarm_expression
=== RUN   TestAccCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_missingStatistic
=== RUN   TestAccCloudWatchMetricAlarm_tags
=== PAUSE TestAccCloudWatchMetricAlarm_tags
=== RUN   TestAccCloudWatchMetricAlarm_disappears
=== PAUSE TestAccCloudWatchMetricAlarm_disappears
=== CONT  TestAccCloudWatchMetricAlarm_basic
=== CONT  TestAccCloudWatchMetricAlarm_extendedStatistic
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== CONT  TestAccCloudWatchMetricAlarm_tags
=== CONT  TestAccCloudWatchMetricAlarm_missingStatistic
=== CONT  TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== CONT  TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT  TestAccCloudWatchMetricAlarm_expression
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== CONT  TestAccCloudWatchMetricAlarm_treatMissingData
=== CONT  TestAccCloudWatchMetricAlarm_disappears
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (9.62s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (19.48s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (24.28s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (24.33s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (27.60s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (27.79s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (28.08s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (36.04s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (51.24s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (56.51s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (99.52s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (219.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	222.795s
GovCloud
% make testacc TESTARGS='-run=TestAccCloudWatchMetricAlarm_' PKG_NAME=internal/service/cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch -v -count 1 -parallel 20 -run=TestAccCloudWatchMetricAlarm_ -timeout 180m
=== RUN   TestAccCloudWatchMetricAlarm_basic
=== PAUSE TestAccCloudWatchMetricAlarm_basic
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== RUN   TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== PAUSE TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== RUN   TestAccCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccCloudWatchMetricAlarm_treatMissingData
=== RUN   TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN   TestAccCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_extendedStatistic
=== RUN   TestAccCloudWatchMetricAlarm_expression
=== PAUSE TestAccCloudWatchMetricAlarm_expression
=== RUN   TestAccCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_missingStatistic
=== RUN   TestAccCloudWatchMetricAlarm_tags
=== PAUSE TestAccCloudWatchMetricAlarm_tags
=== RUN   TestAccCloudWatchMetricAlarm_disappears
=== PAUSE TestAccCloudWatchMetricAlarm_disappears
=== CONT  TestAccCloudWatchMetricAlarm_basic
=== CONT  TestAccCloudWatchMetricAlarm_extendedStatistic
=== CONT  TestAccCloudWatchMetricAlarm_disappears
=== CONT  TestAccCloudWatchMetricAlarm_expression
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== CONT  TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== CONT  TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT  TestAccCloudWatchMetricAlarm_missingStatistic
=== CONT  TestAccCloudWatchMetricAlarm_tags
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== CONT  TestAccCloudWatchMetricAlarm_treatMissingData
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (16.05s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (29.37s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (35.26s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (36.29s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (38.98s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (40.19s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (40.39s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (53.38s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (73.48s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (74.01s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (124.28s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (220.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	223.525s

@ewbankkit
Copy link
Contributor

@nyamada00 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 01132fc into hashicorp:main Oct 19, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 19, 2021
@nyamada00 nyamada00 deleted the b-aws_metric_alarm-8854 branch October 19, 2021 23:39
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perpetual diff on treat_missing_data for imported aws_cloudwatch_metric_alarm
3 participants