-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default value 'missing' for 'treat_missing_data' #21363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @nyamada00 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccCloudWatchMetricAlarm_' PKG_NAME=internal/service/cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch -v -count 1 -parallel 20 -run=TestAccCloudWatchMetricAlarm_ -timeout 180m
=== RUN TestAccCloudWatchMetricAlarm_basic
=== PAUSE TestAccCloudWatchMetricAlarm_basic
=== RUN TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== RUN TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== RUN TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== RUN TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== PAUSE TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== RUN TestAccCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccCloudWatchMetricAlarm_treatMissingData
=== RUN TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN TestAccCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_extendedStatistic
=== RUN TestAccCloudWatchMetricAlarm_expression
=== PAUSE TestAccCloudWatchMetricAlarm_expression
=== RUN TestAccCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_missingStatistic
=== RUN TestAccCloudWatchMetricAlarm_tags
=== PAUSE TestAccCloudWatchMetricAlarm_tags
=== RUN TestAccCloudWatchMetricAlarm_disappears
=== PAUSE TestAccCloudWatchMetricAlarm_disappears
=== CONT TestAccCloudWatchMetricAlarm_basic
=== CONT TestAccCloudWatchMetricAlarm_extendedStatistic
=== CONT TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== CONT TestAccCloudWatchMetricAlarm_tags
=== CONT TestAccCloudWatchMetricAlarm_missingStatistic
=== CONT TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== CONT TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT TestAccCloudWatchMetricAlarm_expression
=== CONT TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== CONT TestAccCloudWatchMetricAlarm_treatMissingData
=== CONT TestAccCloudWatchMetricAlarm_disappears
=== CONT TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (9.62s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (19.48s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (24.28s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (24.33s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (27.60s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (27.79s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (28.08s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (36.04s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (51.24s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (56.51s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (99.52s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (219.87s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch 222.795s
GovCloud
% make testacc TESTARGS='-run=TestAccCloudWatchMetricAlarm_' PKG_NAME=internal/service/cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch -v -count 1 -parallel 20 -run=TestAccCloudWatchMetricAlarm_ -timeout 180m
=== RUN TestAccCloudWatchMetricAlarm_basic
=== PAUSE TestAccCloudWatchMetricAlarm_basic
=== RUN TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== RUN TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== RUN TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== RUN TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== PAUSE TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== RUN TestAccCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccCloudWatchMetricAlarm_treatMissingData
=== RUN TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN TestAccCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_extendedStatistic
=== RUN TestAccCloudWatchMetricAlarm_expression
=== PAUSE TestAccCloudWatchMetricAlarm_expression
=== RUN TestAccCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_missingStatistic
=== RUN TestAccCloudWatchMetricAlarm_tags
=== PAUSE TestAccCloudWatchMetricAlarm_tags
=== RUN TestAccCloudWatchMetricAlarm_disappears
=== PAUSE TestAccCloudWatchMetricAlarm_disappears
=== CONT TestAccCloudWatchMetricAlarm_basic
=== CONT TestAccCloudWatchMetricAlarm_extendedStatistic
=== CONT TestAccCloudWatchMetricAlarm_disappears
=== CONT TestAccCloudWatchMetricAlarm_expression
=== CONT TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== CONT TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== CONT TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== CONT TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT TestAccCloudWatchMetricAlarm_missingStatistic
=== CONT TestAccCloudWatchMetricAlarm_tags
=== CONT TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== CONT TestAccCloudWatchMetricAlarm_treatMissingData
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (16.05s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (29.37s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (35.26s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (36.29s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (38.98s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (40.19s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (40.39s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (53.38s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (73.48s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (74.01s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (124.28s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (220.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch 223.525s
@nyamada00 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes #8854
Output from acceptance testing: