Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.64.1/0 breaks certain FIPS endpoints during terraform plan/apply #21655

Closed
joseph-max-coalfire opened this issue Nov 5, 2021 · 2 comments
Closed
Labels
bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement.

Comments

@joseph-max-coalfire
Copy link

joseph-max-coalfire commented Nov 5, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

image

Affected Resource(s)

  • custom endpoints block within the AWS provider resource
  • Looks like not all AWS FIPS endpoints are broken-- we're seeing issues with the Elasticsearch "es" and Config "config" endpoints but nothing else at the moment reference page in AWS

Terraform Configuration Files

variable "aws_region" {
    default = "us-east-1"
}

provider "aws" {
  region                 = var.aws_region
  version                = ">=3.26"
  skip_region_validation = "true"
  profile                = "default"
  alias                  = "stage"

  //FIPs endpoints for govcloud
//  endpoints {
//    configservice    = "config-fips.${var.aws_region}.amazonaws.com"
//    es         = "es-fips.${var.aws_region}.amazonaws.com"
//  }

    // FIPs endpoints for east/west aws
    endpoints {
      es         = "es-fips.${var.aws_region}.amazonaws.com"
      configservice    = "config-fips.${var.aws_region}.amazonaws.com"

    }
}

Debug Output

link to gist

Expected Behavior

Terraform plan/apply succeeds with these endpoints defined in the provider "aws" stanzas

Actual Behavior

Terraform plan/apply fails, complaining about "An argument named {AWS_service_prefix} is not expected here. Did you mean {another_AWS_service_prefix_that's_not_correct}?

Steps to Reproduce

  1. Create a provider "aws" block within your Terraform code somewhere
  2. Within the provider block, create an endpoints map using AWS FIPS endpoints, with either "es" (AWS Elasticsearch) or "config" (AWS Config)
  3. terraform plan

Downgrading to version 3.63 fixes this

References

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 5, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 5, 2021
@ewbankkit
Copy link
Contributor

@joseph-max-coalfire Thanks for raising this issue.
It has already been noticed in #21646. I'm going to close this one as a duplicate so that we can concentrate discussion in the linked issue.
Please add any additional comments there.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants