Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Redshift settings in DMS target endpoint #21846

Closed
wants to merge 2 commits into from
Closed

Support for Redshift settings in DMS target endpoint #21846

wants to merge 2 commits into from

Conversation

toini
Copy link
Contributor

@toini toini commented Nov 19, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13162

Output from acceptance testing:

$ make testacc TESTS=TestAccDMSEndpoint_redshift PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_redshift' -timeout 180m
=== RUN   TestAccDMSEndpoint_redshift
=== PAUSE TestAccDMSEndpoint_redshift
=== CONT  TestAccDMSEndpoint_redshift
2021/11/19 16:32:56 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:33:08 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:33:08 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:33:08 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:33:10 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:33:10 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:33:13 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:33:13 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:33:14 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:33:16 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:33:16 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:33:19 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:33:22 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:33:33 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:33:44 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:33:55 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:34:06 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:34:17 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:34:28 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:34:39 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:34:50 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:35:00 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:35:11 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:35:22 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:35:33 [INFO] Reading Redshift Cluster Information: tftest
2021/11/19 16:35:42 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:42 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:42 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:35:45 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:45 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:48 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:48 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:48 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:35:50 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:50 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:55 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:55 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:55 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:35:57 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:35:57 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:03 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:36:09 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:09 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:09 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:36:11 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:11 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:16 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:16 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:16 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:36:18 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:18 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:20 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:36:30 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:30 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:30 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:36:32 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:32 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:34 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:34 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:34 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:36:36 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:36 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:42 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:42 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:42 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/19 16:36:43 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:43 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:47 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:47 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2021/11/19 16:36:48 [INFO] AWS Auth provider used: "EnvProvider"
--- PASS: TestAccDMSEndpoint_redshift (301.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        301.849s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/databasemigrationservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/databasemigrationservice labels Nov 19, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/databasemigrationservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 19, 2021
github-actions[bot]
github-actions bot reviewed Nov 19, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @toini 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@toini toini changed the title [WIP] Support for Redshift settings in DMS target endpoint Support for Redshift settings in DMS target endpoint Nov 19, 2021
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2021
@Tiri1992
Copy link

Tiri1992 commented Feb 8, 2022

When will this be merged?

@toini
Copy link
Contributor Author

toini commented Feb 8, 2022

@Tiri1992 I guess we need to people to upvote it with 👍 reaction to get priority. See https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/pullrequest-submission-and-lifecycle.md

@ags2121
Copy link

ags2121 commented May 10, 2022

is there any workaround for setting redshift_settings in TF, or is the only option to manually set those via AWS CLI?

@toini
Copy link
Contributor Author

toini commented May 13, 2022

@ags2121 I'm using a custom build from this PR...

@ewbankkit ewbankkit added the service/dms Issues and PRs that pertain to the dms service. label Jun 2, 2022
@ewbankkit ewbankkit mentioned this pull request Jun 2, 2022
Merged
@ewbankkit
Copy link
Contributor

@toini Thanks for the contribution 🎉 👏.
I have rolled these changes into #25143.

@ewbankkit ewbankkit closed this Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jul 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS DMS Endpoint - Support for redshift settings
6 participants
@toini @Tiri1992 @ags2121 @ewbankkit @justinretzolk @hc-github-team-terraform-aws