Return a different cloudfront hosted_zone_id if in AWS CN

[deamwork]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15223, #18169

Output from acceptance testing:

• Not available since there's no acceptance testing for now.

This PR will return a fixed hosted_zone_id of Route53 with Cloudfront when the user is operating in the AWS China region.

You can review the guidance provided by AWS CN here: https://docs.amazonaws.cn/en_us/aws/latest/userguide/route53.html

I did some tests (acceptance tests are not included) and make test looks fine.

This is my first PR/contribution in this repo. If there's anything I should do, please comment here. Huge thanks.

[github-actions]

Welcome @deamwork 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

@deamwork Thanks for the contribution 🎉 👏.
Overall it looks great.
I simplified the code to use the endpoints.PartitionForRegion function instead of testing the AWS Region prefix,
I also removed the acceptance tests as the maintainers have no way currently of testing in the China partition.

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccCloudFrontDistributionDataSource_basic PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontDistributionDataSource_basic' -timeout 180m
=== RUN   TestAccCloudFrontDistributionDataSource_basic
=== PAUSE TestAccCloudFrontDistributionDataSource_basic
=== CONT  TestAccCloudFrontDistributionDataSource_basic
--- PASS: TestAccCloudFrontDistributionDataSource_basic (320.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	325.935s

[github-actions]

This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.