r/alb: on create, only modify enable_waf_fail_open argument if change is present

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22037

Output from acceptance testing before code change (us-gov-east-1): Test tf config does not explicitly configure enable_waf_fail_open

=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
    load_balancer_test.go:69: Step 1/1 error: Error running apply: exit status 1

        Error: failure configuring LB attributes: ValidationError: Load balancer attribute key 'waf.fail_open.enabled' is not recognized
        	status code: 400, request id: 3294a3f6-a621-4d6d-b60a-bb44a7c4f80b

          with aws_lb.lb_test,
          on terraform_plugin_test.tf line 11, in resource "aws_lb" "lb_test":
          11: resource "aws_lb" "lb_test" {

--- FAIL: TestAccELBV2LoadBalancer_ALB_basic (171.81s)

Output from acceptance testing (us-west-2):

--- PASS: TestAccELBV2LoadBalancer_ALB_basic (158.63s)
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen (311.50s)

Output from acceptance testing (us-gov-west-1):

--- PASS: TestAccELBV2LoadBalancer_ALB_basic (175.30s)
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen (296.87s)

Output from acceptance testing (us-gov-east-1):

--- PASS: TestAccELBV2LoadBalancer_ALB_basic (206.77s)

[ewbankkit]

LGTM 🚀.

us-gov-east-1

% make testacc TESTS=TestAccELBV2LoadBalancer_ALB_basic PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2LoadBalancer_ALB_basic' -timeout 180m
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (166.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	170.064s

us-west-2

% make testacc TESTS=TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen' -timeout 180m
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen (336.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	339.577s

[github-actions]

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.