Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Queued as a StackSet Operating Waiter Pending state #22160

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Adds Queued as a StackSet Operating Waiter Pending state #22160

merged 2 commits into from
Mar 25, 2022

Conversation

georgealton
Copy link
Contributor

@georgealton georgealton commented Dec 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

A StackSet using Managed Execution can internally queue Operations before they're executed.

When doing so the status of the Operation is set to Queued.

Initially, concurrent Operations may also be set to Queued, until they're deemed safe to start.

The waiter doesn't handle the case where the Operation status is Queued. After which terraform loses track of the Operation.

This treats the Queued status as a 'Pending' status in the waiter. Allowing terraform to successfully track Queued Operations, until they reach the Target state.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Dec 10, 2021
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@github-actions github-actions bot removed provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. labels Dec 10, 2021
@georgealton georgealton marked this pull request as ready for review December 10, 2021 17:31
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 10, 2021
@georgealton georgealton changed the title Adds Queued as pending state Adds Queued as a StackSet Operating Waiter Pending state Jan 11, 2022
@ewbankkit
Copy link
Contributor

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCloudFormationStackSet_basic PKG=cloudformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStackSet_basic' -timeout 180m
=== RUN   TestAccCloudFormationStackSet_basic
=== PAUSE TestAccCloudFormationStackSet_basic
=== CONT  TestAccCloudFormationStackSet_basic
--- PASS: TestAccCloudFormationStackSet_basic (22.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	27.431s

@ewbankkit ewbankkit merged commit 6e3e52e into hashicorp:main Mar 25, 2022
@github-actions github-actions bot added this to the v4.8.0 milestone Mar 25, 2022
@ewbankkit ewbankkit modified the milestones: v4.8.0, v4.9.0 Mar 27, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants