-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Queued as a StackSet Operating Waiter Pending state #22160
Adds Queued as a StackSet Operating Waiter Pending state #22160
Conversation
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccCloudFormationStackSet_basic PKG=cloudformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStackSet_basic' -timeout 180m
=== RUN TestAccCloudFormationStackSet_basic
=== PAUSE TestAccCloudFormationStackSet_basic
=== CONT TestAccCloudFormationStackSet_basic
--- PASS: TestAccCloudFormationStackSet_basic (22.56s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation 27.431s
This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
A StackSet using Managed Execution can internally queue Operations before they're executed.
When doing so the status of the Operation is set to Queued.
Initially, concurrent Operations may also be set to Queued, until they're deemed safe to start.
The waiter doesn't handle the case where the Operation status is Queued. After which terraform loses track of the Operation.
This treats the Queued status as a 'Pending' status in the waiter. Allowing terraform to successfully track Queued Operations, until they reach the Target state.