New Resource: aws_ecr_pull_through_cache_rule

[roberth-k]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21951

Implementation of registry_id follows the same pattern as aws_ecr_repository.

Output from acceptance testing:

$ make testacc PKG=ecr TESTS=TestAccPullThroughCacheRule_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccPullThroughCacheRule_' -timeout 180m
=== RUN   TestAccPullThroughCacheRule_basic
=== PAUSE TestAccPullThroughCacheRule_basic
=== RUN   TestAccPullThroughCacheRule_disappears
=== PAUSE TestAccPullThroughCacheRule_disappears
=== RUN   TestAccPullThroughCacheRule_failWhenAlreadyExists
=== PAUSE TestAccPullThroughCacheRule_failWhenAlreadyExists
=== CONT  TestAccPullThroughCacheRule_basic
=== CONT  TestAccPullThroughCacheRule_failWhenAlreadyExists
=== CONT  TestAccPullThroughCacheRule_disappears
--- PASS: TestAccPullThroughCacheRule_failWhenAlreadyExists (15.04s)
--- PASS: TestAccPullThroughCacheRule_disappears (17.12s)
--- PASS: TestAccPullThroughCacheRule_basic (22.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        24.076s

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc PKG=ecr TESTS=TestAccPullThroughCacheRule_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccPullThroughCacheRule_' -timeout 180m
=== RUN   TestAccPullThroughCacheRule_basic
=== PAUSE TestAccPullThroughCacheRule_basic
=== RUN   TestAccPullThroughCacheRule_disappears
=== PAUSE TestAccPullThroughCacheRule_disappears
=== RUN   TestAccPullThroughCacheRule_failWhenAlreadyExists
=== PAUSE TestAccPullThroughCacheRule_failWhenAlreadyExists
=== CONT  TestAccPullThroughCacheRule_basic
=== CONT  TestAccPullThroughCacheRule_failWhenAlreadyExists
=== CONT  TestAccPullThroughCacheRule_disappears
--- PASS: TestAccPullThroughCacheRule_failWhenAlreadyExists (10.56s)
--- PASS: TestAccPullThroughCacheRule_disappears (12.85s)
--- PASS: TestAccPullThroughCacheRule_basic (16.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	20.197s

GovCloud

% make testacc PKG=ecr TESTS=TestAccPullThroughCacheRule_     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccPullThroughCacheRule_' -timeout 180m
=== RUN   TestAccPullThroughCacheRule_basic
=== PAUSE TestAccPullThroughCacheRule_basic
=== RUN   TestAccPullThroughCacheRule_disappears
=== PAUSE TestAccPullThroughCacheRule_disappears
=== RUN   TestAccPullThroughCacheRule_failWhenAlreadyExists
    pull_through_cache_rule_test.go:74: ECR Pull Through Cache Rule is not supported in GovCloud partition
--- SKIP: TestAccPullThroughCacheRule_failWhenAlreadyExists (0.00s)
=== CONT  TestAccPullThroughCacheRule_basic
=== CONT  TestAccPullThroughCacheRule_disappears
    acctest.go:960: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating ECR Pull Through Cache Rule (tf-test-gujssfrf): ValidationException: This feature is disabled
        
          with aws_ecr_pull_through_cache_rule.test,
          on terraform_plugin_test.tf line 2, in resource "aws_ecr_pull_through_cache_rule" "test":
           2: resource "aws_ecr_pull_through_cache_rule" "test" {
        
=== CONT  TestAccPullThroughCacheRule_basic
    acctest.go:960: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating ECR Pull Through Cache Rule (tf-test-sft21ejl): ValidationException: This feature is disabled
        
          with aws_ecr_pull_through_cache_rule.test,
          on terraform_plugin_test.tf line 2, in resource "aws_ecr_pull_through_cache_rule" "test":
           2: resource "aws_ecr_pull_through_cache_rule" "test" {
        
--- SKIP: TestAccPullThroughCacheRule_disappears (7.82s)
--- SKIP: TestAccPullThroughCacheRule_basic (7.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	11.317s

[ewbankkit]

@roberth-k Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.