r/aws_fsx_ontap_storage_virtual_machine: Deprecate organizational_unit_distinguidshed_name in favor of organizational_unit_distinguished_name

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21987.

Deprecates organizational_unit_distinguidshed_name in the active_directory_configuration.self_managed_active_directory_configuration configuration block in favor of organizational_unit_distinguished_name.
Follows the documented best practices adapted for a nested attribute.

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccFSxOntapStorageVirtualMachine_activeDirectory' PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxOntapStorageVirtualMachine_activeDirectory -timeout 180m
=== RUN   TestAccFSxOntapStorageVirtualMachine_activeDirectory
=== PAUSE TestAccFSxOntapStorageVirtualMachine_activeDirectory
=== RUN   TestAccFSxOntapStorageVirtualMachine_activeDirectoryDeprecatedOrganizationalUnitDistinguishedName
=== PAUSE TestAccFSxOntapStorageVirtualMachine_activeDirectoryDeprecatedOrganizationalUnitDistinguishedName
=== CONT  TestAccFSxOntapStorageVirtualMachine_activeDirectory
=== CONT  TestAccFSxOntapStorageVirtualMachine_activeDirectoryDeprecatedOrganizationalUnitDistinguishedName
--- PASS: TestAccFSxOntapStorageVirtualMachine_activeDirectory (2645.81s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_activeDirectoryDeprecatedOrganizationalUnitDistinguishedName (2709.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2712.791s

[YakDriver]

:face_palm:

Fix looks great! 🎉

% make testacc TESTARGS='-run=TestAccFSxOntapStorageVirtualMachine_activeDirectory' PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxOntapStorageVirtualMachine_activeDirectory -timeout 180m
--- PASS: TestAccFSxOntapStorageVirtualMachine_activeDirectoryDeprecatedOrganizationalUnitDistinguishedName (2560.16s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_activeDirectory (2929.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2930.634s

[github-actions]

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[khan-belal]

The typo has been corrected in the new version, however updating my IaC to use the new value (organizational_unit_distinguished_name) is forcing a replacement of my SVM.

This is not ideal, as I have already made configuration changes on the SVM.

The expected behaviour should be that terraform recognizes that both values mean the same thing and that no changes are required.

See my example below:

~ self_managed_active_directory_configuration {
              - organizational_unit_distinguidshed_name = "OU=MyOrgDetails" -> null # forces replacement
              + organizational_unit_distinguished_name  = "OU=MyOrgDetails" # forces replacement

[ewbankkit]

@k1ngkhan Can you please open a new issue for this? Thanks.

[khan-belal]

@ewbankkit I have opened #22286 for this.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.