-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_memorydb_user #22261
Conversation
e677226
to
46714ff
Compare
46714ff
to
708fadc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc PKG=memorydb TESTS=TestAccMemoryDBUser_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 2 -run='TestAccMemoryDBUser_' -timeout 180m
=== RUN TestAccMemoryDBUser_basic
=== PAUSE TestAccMemoryDBUser_basic
=== RUN TestAccMemoryDBUser_disappears
=== PAUSE TestAccMemoryDBUser_disappears
=== RUN TestAccMemoryDBUser_update_accessString
=== PAUSE TestAccMemoryDBUser_update_accessString
=== RUN TestAccMemoryDBUser_update_passwords
=== PAUSE TestAccMemoryDBUser_update_passwords
=== RUN TestAccMemoryDBUser_update_tags
=== PAUSE TestAccMemoryDBUser_update_tags
=== CONT TestAccMemoryDBUser_basic
=== CONT TestAccMemoryDBUser_update_tags
--- PASS: TestAccMemoryDBUser_basic (36.51s)
=== CONT TestAccMemoryDBUser_update_passwords
--- PASS: TestAccMemoryDBUser_update_tags (107.87s)
=== CONT TestAccMemoryDBUser_update_accessString
--- PASS: TestAccMemoryDBUser_update_passwords (187.96s)
=== CONT TestAccMemoryDBUser_disappears
--- PASS: TestAccMemoryDBUser_update_accessString (119.39s)
--- PASS: TestAccMemoryDBUser_disappears (74.60s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 303.694s
GovCloud
% make testacc PKG=memorydb TESTS=TestAccMemoryDBUser_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 2 -run='TestAccMemoryDBUser_' -timeout 180m
=== RUN TestAccMemoryDBUser_basic
=== PAUSE TestAccMemoryDBUser_basic
=== RUN TestAccMemoryDBUser_disappears
=== PAUSE TestAccMemoryDBUser_disappears
=== RUN TestAccMemoryDBUser_update_accessString
=== PAUSE TestAccMemoryDBUser_update_accessString
=== RUN TestAccMemoryDBUser_update_passwords
=== PAUSE TestAccMemoryDBUser_update_passwords
=== RUN TestAccMemoryDBUser_update_tags
=== PAUSE TestAccMemoryDBUser_update_tags
=== CONT TestAccMemoryDBUser_basic
=== CONT TestAccMemoryDBUser_update_passwords
=== CONT TestAccMemoryDBUser_basic
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT TestAccMemoryDBUser_update_passwords
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBUser_basic (1.43s)
=== CONT TestAccMemoryDBUser_update_tags
--- SKIP: TestAccMemoryDBUser_update_passwords (1.43s)
=== CONT TestAccMemoryDBUser_update_accessString
=== CONT TestAccMemoryDBUser_update_tags
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBUser_update_tags (0.00s)
=== CONT TestAccMemoryDBUser_disappears
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBUser_disappears (0.00s)
=== CONT TestAccMemoryDBUser_update_accessString
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBUser_update_accessString (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 6.179s
@roberth-k Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #20631
Depends on PR #22256
Output from acceptance testing: