data_source/aws_vpc_ipam_pool acceptance tests are failing in CI due to parallelism

[drewmullen]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Affected Resource(s)

• aws_vpc_ipam_pool

The data source for IPAM pool searches is failing because it currently returns the first pool it finds that matches its criteria. Due to low availability of filters, its finding the incorrect pool from other CI tests and then the DS arn does not match the API returned arn.

• add an implicit reference ipam_pool_id = aws_vpc_ipam_pool.test.id here so the DS finds the specific one we built in CI
• remove the explicit depends_on from the acc test config
• add an error to the resource if it finds more than 1 pool based on search criteria, example

This change will make this DS less useful for accounts with more than 1 pool but that is currently due to a limitation with the API

[jpalan-amazon]

@drewmullen I picked this up.

[github-actions]

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.