-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/glue_trigger - add start_on_creation
#22439
r/glue_trigger - add start_on_creation
#22439
Conversation
sa
start_on_creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccGlueTrigger_ PKG=glue ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 2 -run='TestAccGlueTrigger_' -timeout 180m
=== RUN TestAccGlueTrigger_basic
=== PAUSE TestAccGlueTrigger_basic
=== RUN TestAccGlueTrigger_crawler
=== PAUSE TestAccGlueTrigger_crawler
=== RUN TestAccGlueTrigger_description
=== PAUSE TestAccGlueTrigger_description
=== RUN TestAccGlueTrigger_enabled
=== PAUSE TestAccGlueTrigger_enabled
=== RUN TestAccGlueTrigger_predicate
=== PAUSE TestAccGlueTrigger_predicate
=== RUN TestAccGlueTrigger_schedule
=== PAUSE TestAccGlueTrigger_schedule
=== RUN TestAccGlueTrigger_startOnCreate
=== PAUSE TestAccGlueTrigger_startOnCreate
=== RUN TestAccGlueTrigger_tags
=== PAUSE TestAccGlueTrigger_tags
=== RUN TestAccGlueTrigger_workflowName
=== PAUSE TestAccGlueTrigger_workflowName
=== RUN TestAccGlueTrigger_Actions_notify
=== PAUSE TestAccGlueTrigger_Actions_notify
=== RUN TestAccGlueTrigger_Actions_security
=== PAUSE TestAccGlueTrigger_Actions_security
=== RUN TestAccGlueTrigger_onDemandDisable
=== PAUSE TestAccGlueTrigger_onDemandDisable
=== RUN TestAccGlueTrigger_disappears
=== PAUSE TestAccGlueTrigger_disappears
=== CONT TestAccGlueTrigger_basic
=== CONT TestAccGlueTrigger_onDemandDisable
--- PASS: TestAccGlueTrigger_basic (33.06s)
=== CONT TestAccGlueTrigger_startOnCreate
--- PASS: TestAccGlueTrigger_onDemandDisable (79.12s)
=== CONT TestAccGlueTrigger_Actions_security
--- PASS: TestAccGlueTrigger_startOnCreate (68.93s)
=== CONT TestAccGlueTrigger_Actions_notify
--- PASS: TestAccGlueTrigger_Actions_security (76.77s)
=== CONT TestAccGlueTrigger_workflowName
--- PASS: TestAccGlueTrigger_workflowName (142.59s)
=== CONT TestAccGlueTrigger_tags
--- PASS: TestAccGlueTrigger_Actions_notify (371.29s)
=== CONT TestAccGlueTrigger_enabled
--- PASS: TestAccGlueTrigger_tags (378.92s)
=== CONT TestAccGlueTrigger_schedule
--- PASS: TestAccGlueTrigger_enabled (289.96s)
=== CONT TestAccGlueTrigger_predicate
--- PASS: TestAccGlueTrigger_schedule (115.96s)
=== CONT TestAccGlueTrigger_description
--- PASS: TestAccGlueTrigger_description (58.84s)
=== CONT TestAccGlueTrigger_disappears
--- PASS: TestAccGlueTrigger_predicate (94.98s)
=== CONT TestAccGlueTrigger_crawler
--- PASS: TestAccGlueTrigger_disappears (27.96s)
--- PASS: TestAccGlueTrigger_crawler (106.54s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 968.355s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22437
Output from acceptance testing: