Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/glue_trigger - add start_on_creation #22439

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 6, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22437

Output from acceptance testing:

$ make testacc TESTS= TestAccGlueTrigger_ PKG=glue
--- PASS: TestAccGlueTrigger_disappears (150.53s)
--- PASS: TestAccGlueTrigger_Actions_security (180.67s)
--- PASS: TestAccGlueTrigger_basic (188.90s)
--- PASS: TestAccGlueTrigger_workflowName (189.36s)
--- PASS: TestAccGlueTrigger_startOnCreate (219.90s)
--- PASS: TestAccGlueTrigger_description (263.74s)
--- PASS: TestAccGlueTrigger_schedule (303.57s)
--- PASS: TestAccGlueTrigger_crawler (303.88s)
--- PASS: TestAccGlueTrigger_predicate (303.88s)
--- PASS: TestAccGlueTrigger_tags (388.45s)
--- PASS: TestAccGlueTrigger_Actions_notify (403.88s)
--- PASS: TestAccGlueTrigger_enabled (410.36s)

@DrFaust92 DrFaust92 changed the title start on create r/glue_trigger - add sa Jan 6, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Jan 6, 2022
@DrFaust92 DrFaust92 changed the title r/glue_trigger - add sa r/glue_trigger - add start_on_creation Jan 6, 2022
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 6, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccGlueTrigger_ PKG=glue ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 2 -run='TestAccGlueTrigger_' -timeout 180m
=== RUN   TestAccGlueTrigger_basic
=== PAUSE TestAccGlueTrigger_basic
=== RUN   TestAccGlueTrigger_crawler
=== PAUSE TestAccGlueTrigger_crawler
=== RUN   TestAccGlueTrigger_description
=== PAUSE TestAccGlueTrigger_description
=== RUN   TestAccGlueTrigger_enabled
=== PAUSE TestAccGlueTrigger_enabled
=== RUN   TestAccGlueTrigger_predicate
=== PAUSE TestAccGlueTrigger_predicate
=== RUN   TestAccGlueTrigger_schedule
=== PAUSE TestAccGlueTrigger_schedule
=== RUN   TestAccGlueTrigger_startOnCreate
=== PAUSE TestAccGlueTrigger_startOnCreate
=== RUN   TestAccGlueTrigger_tags
=== PAUSE TestAccGlueTrigger_tags
=== RUN   TestAccGlueTrigger_workflowName
=== PAUSE TestAccGlueTrigger_workflowName
=== RUN   TestAccGlueTrigger_Actions_notify
=== PAUSE TestAccGlueTrigger_Actions_notify
=== RUN   TestAccGlueTrigger_Actions_security
=== PAUSE TestAccGlueTrigger_Actions_security
=== RUN   TestAccGlueTrigger_onDemandDisable
=== PAUSE TestAccGlueTrigger_onDemandDisable
=== RUN   TestAccGlueTrigger_disappears
=== PAUSE TestAccGlueTrigger_disappears
=== CONT  TestAccGlueTrigger_basic
=== CONT  TestAccGlueTrigger_onDemandDisable
--- PASS: TestAccGlueTrigger_basic (33.06s)
=== CONT  TestAccGlueTrigger_startOnCreate
--- PASS: TestAccGlueTrigger_onDemandDisable (79.12s)
=== CONT  TestAccGlueTrigger_Actions_security
--- PASS: TestAccGlueTrigger_startOnCreate (68.93s)
=== CONT  TestAccGlueTrigger_Actions_notify
--- PASS: TestAccGlueTrigger_Actions_security (76.77s)
=== CONT  TestAccGlueTrigger_workflowName
--- PASS: TestAccGlueTrigger_workflowName (142.59s)
=== CONT  TestAccGlueTrigger_tags
--- PASS: TestAccGlueTrigger_Actions_notify (371.29s)
=== CONT  TestAccGlueTrigger_enabled
--- PASS: TestAccGlueTrigger_tags (378.92s)
=== CONT  TestAccGlueTrigger_schedule
--- PASS: TestAccGlueTrigger_enabled (289.96s)
=== CONT  TestAccGlueTrigger_predicate
--- PASS: TestAccGlueTrigger_schedule (115.96s)
=== CONT  TestAccGlueTrigger_description
--- PASS: TestAccGlueTrigger_description (58.84s)
=== CONT  TestAccGlueTrigger_disappears
--- PASS: TestAccGlueTrigger_predicate (94.98s)
=== CONT  TestAccGlueTrigger_crawler
--- PASS: TestAccGlueTrigger_disappears (27.96s)
--- PASS: TestAccGlueTrigger_crawler (106.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	968.355s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit closed this Jan 6, 2022
@ewbankkit ewbankkit reopened this Jan 6, 2022
@ewbankkit ewbankkit merged commit 358c264 into hashicorp:main Jan 6, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 6, 2022
@DrFaust92 DrFaust92 deleted the glue_trigger_start_on_create branch January 6, 2022 17:36
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_glue_trigger to offer StartOnCreation attribute
2 participants