✨ r/aws_cognito_identity_pool_provider_principal_tag

[danquack]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17345

Output from acceptance testing:

$  make testacc TESTARGS="-run=TestAccCognitoIdentityProviderPrincipalTags_basic" PKG_NAME="./internal/service/cognitoidentity" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/cognitoidentity/... -v -count 1 -parallel 3 -run=TestAccCognitoIdentityProviderPrincipalTags_basic -timeout 180m
=== RUN   TestAccCognitoIdentityProviderPrincipalTags_basic
=== PAUSE TestAccCognitoIdentityProviderPrincipalTags_basic
=== CONT  TestAccCognitoIdentityProviderPrincipalTags_basic
--- PASS: TestAccCognitoIdentityProviderPrincipalTags_basic (31.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	32.911s

$ make testacc TESTARGS="-run=TestAccCognitoIdentityProviderPrincipalTags_updated" PKG_NAME="./internal/service/cognitoidentity" ACCTEST_PARALLELISM=3
'==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/cognitoidentity/... -v -count 1 -parallel 3 -run=TestAccCognitoIdentityProviderPrincipalTags_updated -timeout 180m
=== RUN   TestAccCognitoIdentityProviderPrincipalTags_updated
=== PAUSE TestAccCognitoIdentityProviderPrincipalTags_updated
=== CONT  TestAccCognitoIdentityProviderPrincipalTags_updated
--- PASS: TestAccCognitoIdentityProviderPrincipalTags_updated (56.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	58.145s

$ make testacc TESTARGS="-run=TestAccCognitoIdentityProviderPrincipalTags_disappears" PKG_NAME="./internal/service/cognitoidentity" ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/cognitoidentity/... -v -count 1 -parallel 3 -run=TestAccCognitoIdentityProviderPrincipalTags_disappears -timeout 180m
=== RUN   TestAccCognitoIdentityProviderPrincipalTags_disappears
=== PAUSE TestAccCognitoIdentityProviderPrincipalTags_disappears
=== CONT  TestAccCognitoIdentityProviderPrincipalTags_disappears
--- PASS: TestAccCognitoIdentityProviderPrincipalTags_disappears (30.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	31.735s

Technical Notes/UX Questions:

• Im not all to familiar with this endpoint but it appears when you set use_defaults to true, it overrides the tags you provide. Would we want to the user to be able to set that?
• Second, if use_defaults is entered, the properties would change to what you specify, does that mean that principal_tags should be also computed?

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccCognitoIdentityPoolProviderPrincipalTags_' PKG_NAME=internal/service/cognitoidentity 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidentity/... -v -count 1 -parallel 20 -run=TestAccCognitoIdentityPoolProviderPrincipalTags_ -timeout 180m
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_updated
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_basic (24.10s)
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_disappears (24.47s)
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_updated (40.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	46.050s

GovCloud

% make testacc TESTARGS='-run=TestAccCognitoIdentityPoolProviderPrincipalTags_' PKG_NAME=internal/service/cognitoidentity
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidentity/... -v -count 1 -parallel 20 -run=TestAccCognitoIdentityPoolProviderPrincipalTags_ -timeout 180m
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_updated
=== RUN   TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== PAUSE TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_basic
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_disappears
=== CONT  TestAccCognitoIdentityPoolProviderPrincipalTags_updated
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_basic (25.82s)
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_disappears (25.83s)
--- PASS: TestAccCognitoIdentityPoolProviderPrincipalTags_updated (43.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	47.115s

[ewbankkit]

@danquack Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.