-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/s3_bucket_logging: new resource #22608
Conversation
1e894e8
to
6623846
Compare
ffeacc8
to
dfd36ba
Compare
44a00a8
to
5ac8e8c
Compare
627ad14
to
bfefb27
Compare
daf4b24
to
37ce9d0
Compare
18688a6
to
322647c
Compare
37ce9d0
to
970b7b5
Compare
970b7b5
to
021b940
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
% make testacc TESTS=TestAccS3BucketLogging_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketLogging_' -timeout 180m
--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)
--- PASS: TestAccS3BucketLogging_disappears (24.38s)
--- PASS: TestAccS3BucketLogging_basic (27.20s)
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (68.00s)
--- PASS: TestAccS3BucketLogging_TargetGrantByID (72.10s)
--- PASS: TestAccS3BucketLogging_update (74.84s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 76.238s
% make testacc TESTS='TestAccS3Bucket_Basic_|TestAccS3Bucket_Manage_|TestAccS3Bucket_Replication_|TestAccS3Bucket_Security_|TestAccS3Bucket_Tags_|TestAccS3Bucket_Web_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket_Basic_|TestAccS3Bucket_Manage_|TestAccS3Bucket_Replication_|TestAccS3Bucket_Security_|TestAccS3Bucket_Tags_|TestAccS3Bucket_Web_' -timeout 180m
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (30.39s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (50.00s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (52.11s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (52.86s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (56.02s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (60.27s)
--- PASS: TestAccS3Bucket_Basic_basic (60.63s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (61.37s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (84.62s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (89.06s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (90.41s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (91.39s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (91.45s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (91.79s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (50.65s)
--- PASS: TestAccS3Bucket_Manage_objectLock (103.60s)
--- PASS: TestAccS3Bucket_Security_corsDelete (47.77s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (52.00s)
--- PASS: TestAccS3Bucket_Security_logging (66.47s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (96.06s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (43.22s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (137.91s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (48.88s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (141.19s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (83.85s)
--- PASS: TestAccS3Bucket_Basic_generatedName (45.07s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (91.52s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (126.38s)
--- PASS: TestAccS3Bucket_Manage_versioning (87.91s)
--- PASS: TestAccS3Bucket_Security_grantToACL (75.86s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (46.85s)
--- PASS: TestAccS3Bucket_Security_updateACL (77.45s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (44.64s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (49.80s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (78.41s)
--- PASS: TestAccS3Bucket_Web_simple (119.74s)
--- PASS: TestAccS3Bucket_Basic_acceleration (85.32s)
--- PASS: TestAccS3Bucket_Web_redirect (121.89s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (73.63s)
--- PASS: TestAccS3Bucket_Replication_basic (219.16s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (79.20s)
--- PASS: TestAccS3Bucket_Basic_emptyString (42.07s)
--- PASS: TestAccS3Bucket_Web_routingRules (80.65s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (221.91s)
--- PASS: TestAccS3Bucket_Tags_basic (46.81s)
--- PASS: TestAccS3Bucket_Security_updateGrant (119.73s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (14.86s)
--- PASS: TestAccS3Bucket_Security_policy (120.92s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (260.90s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (118.25s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (162.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 349.229s
021b940
to
a85f96d
Compare
1646ecd
to
fe1c94f
Compare
Output of acceptance tests after update:
|
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #4418
Relates #20433
Output from acceptance testing: