Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_cloudfront_realtime_log_config #22620

Merged
merged 1 commit into from
Feb 4, 2022
Merged

d/aws_cloudfront_realtime_log_config #22620

merged 1 commit into from
Feb 4, 2022

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Jan 17, 2022 •
edited by justinretzolk

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18426

Output from acceptance testing:

this PR is good, I just didn’t have my aws account for running the tests.

$  make testacc TESTARGS="-run=TestAccCloudFrontRealtimeLogConfigDataSource_basic" PKG_NAME="./internal/service/cloudfront" ACCTEST_PARALLELISM=3

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jan 17, 2022
drewmullen
drewmullen approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

make testacc TESTARGS="-run=TestAccCloudFrontRealtimeLogConfigDataSource_basic" PKG_NAME="./internal/service/cloudfront" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/cloudfront/... -v -count 1 -parallel 3  -run=TestAccCloudFrontRealtimeLogConfigDataSource_basic -timeout 180m
=== RUN   TestAccCloudFrontRealtimeLogConfigDataSource_basic
=== PAUSE TestAccCloudFrontRealtimeLogConfigDataSource_basic
=== CONT  TestAccCloudFrontRealtimeLogConfigDataSource_basic
--- PASS: TestAccCloudFrontRealtimeLogConfigDataSource_basic (48.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	51.905s

@danquack danquack marked this pull request as ready for review January 25, 2022 14:09
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 25, 2022
ewbankkit
ewbankkit approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCloudFrontRealtimeLogConfigDataSource_ PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontRealtimeLogConfigDataSource_'  -timeout 180m
=== RUN   TestAccCloudFrontRealtimeLogConfigDataSource_basic
=== PAUSE TestAccCloudFrontRealtimeLogConfigDataSource_basic
=== CONT  TestAccCloudFrontRealtimeLogConfigDataSource_basic
--- PASS: TestAccCloudFrontRealtimeLogConfigDataSource_basic (45.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	49.493s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6aa5051 into hashicorp:main Feb 4, 2022
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 4, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@drewmullen drewmullen drewmullen approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

cloudfront: 'data' support for aws_cloudfront_realtime_log_config
4 participants
@danquack @ewbankkit @drewmullen @justinretzolk