r/autoscaling_attachment: deprecate alb_target_group_arn and add lb_target_group_arn
#22662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
anGie44
force-pushed
the
f-deprecate-alb-target-group-name
branch
from
998c719 to
6a605b2
Compare
github-actions
bot
added
documentation
github-actions
bot
added
size/M
anGie44
added a commit
that referenced
this pull request
Jan 19, 2022
anGie44
force-pushed
the
release/4.x
branch
3 times, most recently
from
1e894e8 to
6623846
Compare
ewbankkit
force-pushed
the
release/4.x
branch
from
ffeacc8 to
dfd36ba
Compare
anGie44
force-pushed
the
release/4.x
branch
3 times, most recently
from
3ea0d21 to
3468d16
Compare
anGie44
force-pushed
the
release/4.x
branch
4 times, most recently
from
18688a6 to
322647c
Compare
anGie44
force-pushed
the
f-deprecate-alb-target-group-name
branch
from
3b98b9d to
de289f8
Compare
anGie44
force-pushed
the
f-deprecate-alb-target-group-name
branch
from
de289f8 to
3ec899e
Compare
ewbankkit
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAutoScalingAttachment_' PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run=TestAccAutoScalingAttachment_ -timeout 180m
=== RUN TestAccAutoScalingAttachment_elb
=== PAUSE TestAccAutoScalingAttachment_elb
=== RUN TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== CONT TestAccAutoScalingAttachment_elb
=== CONT TestAccAutoScalingAttachment_albTargetGroup
--- PASS: TestAccAutoScalingAttachment_elb (187.56s)
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (192.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 196.444s
|
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #5407
Relates #20433
Description
alb_target_group_arnfor removal in 5.0Output from acceptance testing: