Reduce minimum file system throughput for aws_fsx_ontap_file_system

[lvthillo]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22896

Output from acceptance testing:

make testacc TESTS=TestAccFSxOntapFileSystem PKG=fsx      

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOntapFileSystem'  -timeout 180m
=== RUN   TestAccFSxOntapFileSystem_basic
=== PAUSE TestAccFSxOntapFileSystem_basic
=== RUN   TestAccFSxOntapFileSystem_fsxAdminPassword
=== PAUSE TestAccFSxOntapFileSystem_fsxAdminPassword
=== RUN   TestAccFSxOntapFileSystem_endpointIPAddressRange
=== PAUSE TestAccFSxOntapFileSystem_endpointIPAddressRange
=== RUN   TestAccFSxOntapFileSystem_diskIops
=== PAUSE TestAccFSxOntapFileSystem_diskIops
=== RUN   TestAccFSxOntapFileSystem_disappears
=== PAUSE TestAccFSxOntapFileSystem_disappears
=== RUN   TestAccFSxOntapFileSystem_securityGroupIDs
=== PAUSE TestAccFSxOntapFileSystem_securityGroupIDs
=== RUN   TestAccFSxOntapFileSystem_routeTableIDs
=== PAUSE TestAccFSxOntapFileSystem_routeTableIDs
=== RUN   TestAccFSxOntapFileSystem_tags
=== PAUSE TestAccFSxOntapFileSystem_tags
=== RUN   TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccFSxOntapFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxOntapFileSystem_automaticBackupRetentionDays
=== RUN   TestAccFSxOntapFileSystem_kmsKeyID
=== PAUSE TestAccFSxOntapFileSystem_kmsKeyID
=== RUN   TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccFSxOntapFileSystem_basic
=== CONT  TestAccFSxOntapFileSystem_routeTableIDs
=== CONT  TestAccFSxOntapFileSystem_fsxAdminPassword
=== CONT  TestAccFSxOntapFileSystem_automaticBackupRetentionDays
=== CONT  TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccFSxOntapFileSystem_kmsKeyID
=== CONT  TestAccFSxOntapFileSystem_diskIops
=== CONT  TestAccFSxOntapFileSystem_securityGroupIDs
=== CONT  TestAccFSxOntapFileSystem_disappears
=== CONT  TestAccFSxOntapFileSystem_endpointIPAddressRange
=== CONT  TestAccFSxOntapFileSystem_tags
=== CONT  TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime
=== CONT  TestAccFSxOntapFileSystem_kmsKeyID
    ontap_file_system_test.go:389: Step 1/2 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 95c011e1-1a38-4a04-8464-48bdc1a762ab
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 13, in resource "aws_vpc" "test":
          13: resource "aws_vpc" "test" {
        
--- FAIL: TestAccFSxOntapFileSystem_kmsKeyID (14.09s)
--- PASS: TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime (1963.30s)
--- PASS: TestAccFSxOntapFileSystem_basic (2044.43s)
--- PASS: TestAccFSxOntapFileSystem_disappears (2071.60s)
--- PASS: TestAccFSxOntapFileSystem_endpointIPAddressRange (2126.82s)
--- PASS: TestAccFSxOntapFileSystem_diskIops (2126.83s)
--- PASS: TestAccFSxOntapFileSystem_routeTableIDs (2148.23s)
--- PASS: TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime (2170.81s)
--- PASS: TestAccFSxOntapFileSystem_tags (2276.13s)
--- PASS: TestAccFSxOntapFileSystem_fsxAdminPassword (2353.00s)
--- PASS: TestAccFSxOntapFileSystem_automaticBackupRetentionDays (2356.43s)
--- PASS: TestAccFSxOntapFileSystem_securityGroupIDs (4040.22s)

Rerun of KMS test (failed because of max number of VPCs was reached in my region/account):
$ make testacc TESTS=TestAccFSxOntapFileSystem_kmsKeyID PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOntapFileSystem_kmsKeyID'  -timeout 180m
=== RUN   TestAccFSxOntapFileSystem_kmsKeyID
=== PAUSE TestAccFSxOntapFileSystem_kmsKeyID
=== CONT  TestAccFSxOntapFileSystem_kmsKeyID
--- PASS: TestAccFSxOntapFileSystem_kmsKeyID (2409.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        2413.142s

Example usage:

resource "aws_fsx_ontap_file_system" "test" {
  storage_capacity    = 1024
  subnet_ids          = [aws_subnet.test1.id, aws_subnet.test2.id]
  deployment_type     = "MULTI_AZ_1"
  throughput_capacity = 128
  preferred_subnet_id = aws_subnet.test1.id
}

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccFSxOntapFileSystem_ PKG=fsx ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 5 -run='TestAccFSxOntapFileSystem_'  -timeout 180m
=== RUN   TestAccFSxOntapFileSystem_basic
=== PAUSE TestAccFSxOntapFileSystem_basic
=== RUN   TestAccFSxOntapFileSystem_fsxAdminPassword
=== PAUSE TestAccFSxOntapFileSystem_fsxAdminPassword
=== RUN   TestAccFSxOntapFileSystem_endpointIPAddressRange
=== PAUSE TestAccFSxOntapFileSystem_endpointIPAddressRange
=== RUN   TestAccFSxOntapFileSystem_diskIops
=== PAUSE TestAccFSxOntapFileSystem_diskIops
=== RUN   TestAccFSxOntapFileSystem_disappears
=== PAUSE TestAccFSxOntapFileSystem_disappears
=== RUN   TestAccFSxOntapFileSystem_securityGroupIDs
=== PAUSE TestAccFSxOntapFileSystem_securityGroupIDs
=== RUN   TestAccFSxOntapFileSystem_routeTableIDs
=== PAUSE TestAccFSxOntapFileSystem_routeTableIDs
=== RUN   TestAccFSxOntapFileSystem_tags
=== PAUSE TestAccFSxOntapFileSystem_tags
=== RUN   TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccFSxOntapFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxOntapFileSystem_automaticBackupRetentionDays
=== RUN   TestAccFSxOntapFileSystem_kmsKeyID
=== PAUSE TestAccFSxOntapFileSystem_kmsKeyID
=== RUN   TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccFSxOntapFileSystem_basic
=== CONT  TestAccFSxOntapFileSystem_routeTableIDs
=== CONT  TestAccFSxOntapFileSystem_diskIops
=== CONT  TestAccFSxOntapFileSystem_securityGroupIDs
=== CONT  TestAccFSxOntapFileSystem_disappears
--- PASS: TestAccFSxOntapFileSystem_basic (1987.20s)
=== CONT  TestAccFSxOntapFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxOntapFileSystem_diskIops (2030.51s)
=== CONT  TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccFSxOntapFileSystem_disappears (2103.77s)
=== CONT  TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime
=== CONT  TestAccFSxOntapFileSystem_routeTableIDs
    ontap_file_system_test.go:233: Step 1/2 error: Error running apply: exit status 1
        
        Error: error waiting for FSx ONTAP File System (fs-0869b3a29670b19c7) create: timeout while waiting for state to become 'AVAILABLE' (last state: 'CREATING', timeout: 1h0m0s)
        
          with aws_fsx_ontap_file_system.test,
          on terraform_plugin_test.tf line 62, in resource "aws_fsx_ontap_file_system" "test":
          62: resource "aws_fsx_ontap_file_system" "test" {
        
--- PASS: TestAccFSxOntapFileSystem_securityGroupIDs (4060.80s)
=== CONT  TestAccFSxOntapFileSystem_endpointIPAddressRange
--- PASS: TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime (2064.68s)
=== CONT  TestAccFSxOntapFileSystem_kmsKeyID
--- PASS: TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime (2190.34s)
=== CONT  TestAccFSxOntapFileSystem_fsxAdminPassword
--- FAIL: TestAccFSxOntapFileSystem_routeTableIDs (4322.67s)
=== CONT  TestAccFSxOntapFileSystem_tags
--- PASS: TestAccFSxOntapFileSystem_automaticBackupRetentionDays (2357.42s)
--- PASS: TestAccFSxOntapFileSystem_endpointIPAddressRange (2129.24s)
--- PASS: TestAccFSxOntapFileSystem_kmsKeyID (2253.67s)
--- PASS: TestAccFSxOntapFileSystem_tags (2134.37s)
--- PASS: TestAccFSxOntapFileSystem_fsxAdminPassword (2263.56s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	6488.809s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change.

[ewbankkit]

@lvthillo Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.