-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2/customer_gateway: Remove empty validation #22926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccEC2CustomerGateway_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2CustomerGateway_' -timeout 180m
=== RUN TestAccEC2CustomerGateway_basic
=== PAUSE TestAccEC2CustomerGateway_basic
=== RUN TestAccEC2CustomerGateway_disappears
=== PAUSE TestAccEC2CustomerGateway_disappears
=== RUN TestAccEC2CustomerGateway_tags
=== PAUSE TestAccEC2CustomerGateway_tags
=== RUN TestAccEC2CustomerGateway_deviceName
=== PAUSE TestAccEC2CustomerGateway_deviceName
=== RUN TestAccEC2CustomerGateway_4ByteASN
=== PAUSE TestAccEC2CustomerGateway_4ByteASN
=== RUN TestAccEC2CustomerGateway_certificate
=== PAUSE TestAccEC2CustomerGateway_certificate
=== CONT TestAccEC2CustomerGateway_basic
=== CONT TestAccEC2CustomerGateway_deviceName
=== CONT TestAccEC2CustomerGateway_tags
=== CONT TestAccEC2CustomerGateway_4ByteASN
=== CONT TestAccEC2CustomerGateway_disappears
=== CONT TestAccEC2CustomerGateway_certificate
--- PASS: TestAccEC2CustomerGateway_disappears (31.16s)
--- PASS: TestAccEC2CustomerGateway_deviceName (37.09s)
--- PASS: TestAccEC2CustomerGateway_basic (37.32s)
--- PASS: TestAccEC2CustomerGateway_4ByteASN (37.35s)
--- PASS: TestAccEC2CustomerGateway_tags (68.26s)
--- PASS: TestAccEC2CustomerGateway_certificate (118.66s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 123.002s
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #13943
Output from acceptance testing: