Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2/customer_gateway: Remove empty validation #22926

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 3, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13943

Output from acceptance testing:

% make testacc TESTS=TestAccEC2CustomerGateway PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2CustomerGateway'  -timeout 180m
--- PASS: TestAccEC2CustomerGateway_disappears (27.07s)
--- PASS: TestAccEC2CustomerGatewayDataSource_id (31.32s)
--- PASS: TestAccEC2CustomerGatewayDataSource_filter (31.36s)
--- PASS: TestAccEC2CustomerGateway_basic (31.73s)
--- PASS: TestAccEC2CustomerGateway_deviceName (31.94s)
--- PASS: TestAccEC2CustomerGateway_4ByteASN (32.40s)
--- PASS: TestAccEC2CustomerGateway_tags (56.20s)
--- PASS: TestAccEC2CustomerGateway_certificate (121.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	122.712s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. labels Feb 3, 2022
@YakDriver YakDriver added this to the v4.0.0 milestone Feb 3, 2022
@ewbankkit ewbankkit self-requested a review February 3, 2022 21:17
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccEC2CustomerGateway_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2CustomerGateway_'  -timeout 180m
=== RUN   TestAccEC2CustomerGateway_basic
=== PAUSE TestAccEC2CustomerGateway_basic
=== RUN   TestAccEC2CustomerGateway_disappears
=== PAUSE TestAccEC2CustomerGateway_disappears
=== RUN   TestAccEC2CustomerGateway_tags
=== PAUSE TestAccEC2CustomerGateway_tags
=== RUN   TestAccEC2CustomerGateway_deviceName
=== PAUSE TestAccEC2CustomerGateway_deviceName
=== RUN   TestAccEC2CustomerGateway_4ByteASN
=== PAUSE TestAccEC2CustomerGateway_4ByteASN
=== RUN   TestAccEC2CustomerGateway_certificate
=== PAUSE TestAccEC2CustomerGateway_certificate
=== CONT  TestAccEC2CustomerGateway_basic
=== CONT  TestAccEC2CustomerGateway_deviceName
=== CONT  TestAccEC2CustomerGateway_tags
=== CONT  TestAccEC2CustomerGateway_4ByteASN
=== CONT  TestAccEC2CustomerGateway_disappears
=== CONT  TestAccEC2CustomerGateway_certificate
--- PASS: TestAccEC2CustomerGateway_disappears (31.16s)
--- PASS: TestAccEC2CustomerGateway_deviceName (37.09s)
--- PASS: TestAccEC2CustomerGateway_basic (37.32s)
--- PASS: TestAccEC2CustomerGateway_4ByteASN (37.35s)
--- PASS: TestAccEC2CustomerGateway_tags (68.26s)
--- PASS: TestAccEC2CustomerGateway_certificate (118.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	123.002s

@YakDriver YakDriver merged commit 9b97d6a into main Feb 3, 2022
@YakDriver YakDriver deleted the td-remove-zero-values-attrib-valid branch February 3, 2022 21:41
github-actions bot pushed a commit that referenced this pull request Feb 3, 2022
anGie44 pushed a commit that referenced this pull request Feb 4, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants