Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/fsx_lustre_file_system - add log_configuration argument #22935

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Feb 4, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22886

Output from acceptance testing:

$ make testacc TESTS=TestAccFSxLustreFileSystem_ PKG=fsx

--- PASS: TestAccFSxLustreFileSystem_logConfig (834.76s)
--- PASS: TestAccFSxLustreFileSystem_basic (628.66s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Feb 4, 2022
@DrFaust92 DrFaust92 changed the title r/fsx_lustre_file_system - log config r/fsx_lustre_file_system - add log_configuration argument Feb 4, 2022
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 4, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccFSxLustreFileSystem_ PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxLustreFileSystem_'  -timeout 180m
=== RUN   TestAccFSxLustreFileSystem_basic
=== PAUSE TestAccFSxLustreFileSystem_basic
=== RUN   TestAccFSxLustreFileSystem_disappears
=== PAUSE TestAccFSxLustreFileSystem_disappears
=== RUN   TestAccFSxLustreFileSystem_dataCompression
=== PAUSE TestAccFSxLustreFileSystem_dataCompression
=== RUN   TestAccFSxLustreFileSystem_exportPath
=== PAUSE TestAccFSxLustreFileSystem_exportPath
=== RUN   TestAccFSxLustreFileSystem_importPath
=== PAUSE TestAccFSxLustreFileSystem_importPath
=== RUN   TestAccFSxLustreFileSystem_importedFileChunkSize
=== PAUSE TestAccFSxLustreFileSystem_importedFileChunkSize
=== RUN   TestAccFSxLustreFileSystem_securityGroupIDs
=== PAUSE TestAccFSxLustreFileSystem_securityGroupIDs
=== RUN   TestAccFSxLustreFileSystem_storageCapacity
=== PAUSE TestAccFSxLustreFileSystem_storageCapacity
=== RUN   TestAccFSxLustreFileSystem_storageCapacityUpdate
=== PAUSE TestAccFSxLustreFileSystem_storageCapacityUpdate
=== RUN   TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== PAUSE TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== RUN   TestAccFSxLustreFileSystem_tags
=== PAUSE TestAccFSxLustreFileSystem_tags
=== RUN   TestAccFSxLustreFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxLustreFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccFSxLustreFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxLustreFileSystem_automaticBackupRetentionDays
=== RUN   TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent1
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent1
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== RUN   TestAccFSxLustreFileSystem_logConfig
=== PAUSE TestAccFSxLustreFileSystem_logConfig
=== RUN   TestAccFSxLustreFileSystem_fromBackup
=== PAUSE TestAccFSxLustreFileSystem_fromBackup
=== RUN   TestAccFSxLustreFileSystem_kmsKeyID
=== PAUSE TestAccFSxLustreFileSystem_kmsKeyID
=== RUN   TestAccFSxLustreFileSystem_deploymentTypeScratch2
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypeScratch2
=== RUN   TestAccFSxLustreFileSystem_storageTypeHddDriveCacheRead
=== PAUSE TestAccFSxLustreFileSystem_storageTypeHddDriveCacheRead
=== RUN   TestAccFSxLustreFileSystem_storageTypeHddDriveCacheNone
=== PAUSE TestAccFSxLustreFileSystem_storageTypeHddDriveCacheNone
=== RUN   TestAccFSxLustreFileSystem_copyTagsToBackups
=== PAUSE TestAccFSxLustreFileSystem_copyTagsToBackups
=== RUN   TestAccFSxLustreFileSystem_autoImportPolicy
=== PAUSE TestAccFSxLustreFileSystem_autoImportPolicy
=== CONT  TestAccFSxLustreFileSystem_basic
=== CONT  TestAccFSxLustreFileSystem_automaticBackupRetentionDays
=== CONT  TestAccFSxLustreFileSystem_deploymentTypeScratch2
=== CONT  TestAccFSxLustreFileSystem_securityGroupIDs
=== CONT  TestAccFSxLustreFileSystem_weeklyMaintenanceStartTime
=== CONT  TestAccFSxLustreFileSystem_tags
=== CONT  TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== CONT  TestAccFSxLustreFileSystem_storageCapacityUpdate
=== CONT  TestAccFSxLustreFileSystem_storageCapacity
=== CONT  TestAccFSxLustreFileSystem_exportPath
=== CONT  TestAccFSxLustreFileSystem_kmsKeyID
=== CONT  TestAccFSxLustreFileSystem_importedFileChunkSize
=== CONT  TestAccFSxLustreFileSystem_autoImportPolicy
=== CONT  TestAccFSxLustreFileSystem_copyTagsToBackups
=== CONT  TestAccFSxLustreFileSystem_storageTypeHddDriveCacheNone
=== CONT  TestAccFSxLustreFileSystem_storageTypeHddDriveCacheRead
=== CONT  TestAccFSxLustreFileSystem_importPath
=== CONT  TestAccFSxLustreFileSystem_disappears
=== CONT  TestAccFSxLustreFileSystem_dataCompression
=== CONT  TestAccFSxLustreFileSystem_fromBackup
--- PASS: TestAccFSxLustreFileSystem_basic (581.12s)
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent2
--- PASS: TestAccFSxLustreFileSystem_deploymentTypeScratch2 (621.62s)
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent1
--- PASS: TestAccFSxLustreFileSystem_tags (623.55s)
=== CONT  TestAccFSxLustreFileSystem_logConfig
--- PASS: TestAccFSxLustreFileSystem_storageTypeHddDriveCacheNone (638.83s)
=== CONT  TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccFSxLustreFileSystem_weeklyMaintenanceStartTime (655.46s)
--- PASS: TestAccFSxLustreFileSystem_copyTagsToBackups (663.02s)
--- PASS: TestAccFSxLustreFileSystem_disappears (693.27s)
--- PASS: TestAccFSxLustreFileSystem_storageTypeHddDriveCacheRead (702.19s)
--- PASS: TestAccFSxLustreFileSystem_automaticBackupRetentionDays (746.55s)
--- PASS: TestAccFSxLustreFileSystem_dataCompression (821.90s)
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent2 (570.58s)
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent1 (546.88s)
--- PASS: TestAccFSxLustreFileSystem_securityGroupIDs (1210.59s)
--- PASS: TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime (635.42s)
--- PASS: TestAccFSxLustreFileSystem_fileSystemTypeVersion (1293.26s)
--- PASS: TestAccFSxLustreFileSystem_storageCapacity (1313.32s)
--- PASS: TestAccFSxLustreFileSystem_fromBackup (1337.51s)
--- PASS: TestAccFSxLustreFileSystem_autoImportPolicy (1374.06s)
--- PASS: TestAccFSxLustreFileSystem_kmsKeyID (1394.19s)
--- PASS: TestAccFSxLustreFileSystem_logConfig (789.45s)
--- PASS: TestAccFSxLustreFileSystem_importedFileChunkSize (1742.45s)
--- PASS: TestAccFSxLustreFileSystem_importPath (1841.07s)
--- PASS: TestAccFSxLustreFileSystem_exportPath (1866.29s)
--- PASS: TestAccFSxLustreFileSystem_storageCapacityUpdate (2717.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2724.236s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e7bb427 into hashicorp:main Feb 4, 2022
@DrFaust92 DrFaust92 deleted the fsx-lustre-log branch February 4, 2022 15:11
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 4, 2022
@AlonAvrahami
Copy link

Thank you @DrFaust92 !

@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource: aws_fsx_lustre_file_system missing logging configurations
3 participants