Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_endpoint_configuration - emptiness check for arguments #22960

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Feb 4, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22951

Output from acceptance testing:

$ make testacc TESTS=TestAccSageMakerEndpointConfiguration_ PKG=sagemaker

--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight (66.56s)
--- PASS: TestAccSageMakerEndpointConfiguration_disappears (76.99s)
--- PASS: TestAccSageMakerEndpointConfiguration_async_kms (78.75s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_notif (79.43s)
--- PASS: TestAccSageMakerEndpointConfiguration_kmsKeyID (79.92s)
--- PASS: TestAccSageMakerEndpointConfiguration_basic (84.00s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType (86.35s)
--- PASS: TestAccSageMakerEndpointConfiguration_async (87.44s)
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (92.29s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client (97.61s)
--- PASS: TestAccSageMakerEndpointConfiguration_tags (160.39s)

@github-actions github-actions bot added service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Feb 4, 2022
@DrFaust92 DrFaust92 changed the title r/sagemaker_endpoint_configuration r/sagemaker_endpoint_configuration - emptiness check or nested arguments Feb 4, 2022
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Feb 4, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review February 4, 2022 21:48
@DrFaust92 DrFaust92 changed the title r/sagemaker_endpoint_configuration - emptiness check or nested arguments r/sagemaker_endpoint_configuration - emptiness check for arguments Feb 4, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccSageMakerEndpointConfiguration_ PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerEndpointConfiguration_'  -timeout 180m
=== RUN   TestAccSageMakerEndpointConfiguration_basic
=== PAUSE TestAccSageMakerEndpointConfiguration_basic
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== RUN   TestAccSageMakerEndpointConfiguration_kmsKeyID
=== PAUSE TestAccSageMakerEndpointConfiguration_kmsKeyID
=== RUN   TestAccSageMakerEndpointConfiguration_tags
=== PAUSE TestAccSageMakerEndpointConfiguration_tags
=== RUN   TestAccSageMakerEndpointConfiguration_dataCapture
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture
=== RUN   TestAccSageMakerEndpointConfiguration_disappears
=== PAUSE TestAccSageMakerEndpointConfiguration_disappears
=== RUN   TestAccSageMakerEndpointConfiguration_async
=== PAUSE TestAccSageMakerEndpointConfiguration_async
=== RUN   TestAccSageMakerEndpointConfiguration_async_kms
=== PAUSE TestAccSageMakerEndpointConfiguration_async_kms
=== RUN   TestAccSageMakerEndpointConfiguration_Async_notif
=== PAUSE TestAccSageMakerEndpointConfiguration_Async_notif
=== RUN   TestAccSageMakerEndpointConfiguration_Async_client
=== PAUSE TestAccSageMakerEndpointConfiguration_Async_client
=== CONT  TestAccSageMakerEndpointConfiguration_basic
=== CONT  TestAccSageMakerEndpointConfiguration_disappears
=== CONT  TestAccSageMakerEndpointConfiguration_Async_notif
=== CONT  TestAccSageMakerEndpointConfiguration_Async_client
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== CONT  TestAccSageMakerEndpointConfiguration_kmsKeyID
=== CONT  TestAccSageMakerEndpointConfiguration_dataCapture
=== CONT  TestAccSageMakerEndpointConfiguration_tags
=== CONT  TestAccSageMakerEndpointConfiguration_async_kms
=== CONT  TestAccSageMakerEndpointConfiguration_async
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
--- PASS: TestAccSageMakerEndpointConfiguration_basic (55.03s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight (55.17s)
--- PASS: TestAccSageMakerEndpointConfiguration_async_kms (57.87s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType (58.19s)
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (62.44s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client (62.58s)
--- PASS: TestAccSageMakerEndpointConfiguration_async (62.91s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_notif (62.91s)
--- PASS: TestAccSageMakerEndpointConfiguration_disappears (64.21s)
--- PASS: TestAccSageMakerEndpointConfiguration_kmsKeyID (72.14s)
--- PASS: TestAccSageMakerEndpointConfiguration_tags (114.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	120.446s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c75c99a into hashicorp:main Feb 11, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 11, 2022
@DrFaust92 DrFaust92 deleted the sagemaker-endpoint-config branch February 12, 2022 12:53
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SageMaker aws_sagemaker_endpoint_configuration kms_key_id should be optional
2 participants