Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/gamelift_build - import + object_version support #22966

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Feb 5, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20332

Output from acceptance testing:

$ make testacc TESTS=TestAccGameLiftBuild_ PKG=gamelift

--- PASS: TestAccGameLiftBuild_disappears (36.64s)
--- PASS: TestAccGameLiftBuild_basic (78.08s)
--- PASS: TestAccGameLiftBuild_tags (110.44s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/gamelift Issues and PRs that pertain to the gamelift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Feb 5, 2022
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 6, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccGameLiftBuild_ PKG=gamelift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run='TestAccGameLiftBuild_'  -timeout 180m
=== RUN   TestAccGameLiftBuild_basic
=== PAUSE TestAccGameLiftBuild_basic
=== RUN   TestAccGameLiftBuild_tags
=== PAUSE TestAccGameLiftBuild_tags
=== RUN   TestAccGameLiftBuild_disappears
=== PAUSE TestAccGameLiftBuild_disappears
=== CONT  TestAccGameLiftBuild_basic
=== CONT  TestAccGameLiftBuild_disappears
=== CONT  TestAccGameLiftBuild_tags
--- PASS: TestAccGameLiftBuild_disappears (21.04s)
--- PASS: TestAccGameLiftBuild_basic (46.36s)
--- PASS: TestAccGameLiftBuild_tags (63.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/gamelift	69.362s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7c6b73a into hashicorp:main Feb 11, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 11, 2022
@DrFaust92 DrFaust92 deleted the gamelift_build_import branch February 11, 2022 15:31
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/gamelift Issues and PRs that pertain to the gamelift service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_gamelift_build not waiting for aws_iam_role
2 participants