New Resource: aws_athena_data_catalog

[bschaatsbergen]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22714

Output from acceptance testing:

$ make testacc TESTS=TestAccDataCatalog PKG=athena
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 20 -run='TestAccDataCatalog'  -timeout 180m
=== RUN   TestAccDataCatalog_basic
=== PAUSE TestAccDataCatalog_basic
=== RUN   TestAccDataCatalog_type_lambda
=== PAUSE TestAccDataCatalog_type_lambda
=== RUN   TestAccDataCatalog_type_hive
=== PAUSE TestAccDataCatalog_type_hive
=== RUN   TestAccDataCatalog_type_glue
=== PAUSE TestAccDataCatalog_type_glue
=== RUN   TestAccDataCatalog_parameters
=== PAUSE TestAccDataCatalog_parameters
=== RUN   TestAccDataCatalog_disappears
=== PAUSE TestAccDataCatalog_disappears
=== CONT  TestAccDataCatalog_basic
=== CONT  TestAccDataCatalog_type_glue
=== CONT  TestAccDataCatalog_type_hive
=== CONT  TestAccDataCatalog_type_lambda
=== CONT  TestAccDataCatalog_disappears
=== CONT  TestAccDataCatalog_parameters
--- PASS: TestAccDataCatalog_disappears (27.24s)
--- PASS: TestAccDataCatalog_parameters (37.08s)
--- PASS: TestAccDataCatalog_type_hive (37.08s)
--- PASS: TestAccDataCatalog_type_glue (37.15s)
--- PASS: TestAccDataCatalog_basic (37.18s)
--- PASS: TestAccDataCatalog_type_lambda (37.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/athena     37.293s

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[DrFaust92]

bschaatsbergen can you rebase?

[bschaatsbergen]

bschaatsbergen can you rebase?

Rebased, I have to check this PR again honestly as it's been some time and I ran into w/e I mentioned above here. What do you think? @DrFaust92

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccAthenaDataCatalog_ PKG=athena ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 3 -run='TestAccAthenaDataCatalog_'  -timeout 180m
=== RUN   TestAccAthenaDataCatalog_basic
=== PAUSE TestAccAthenaDataCatalog_basic
=== RUN   TestAccAthenaDataCatalog_tags
=== PAUSE TestAccAthenaDataCatalog_tags
=== RUN   TestAccAthenaDataCatalog_type_lambda
=== PAUSE TestAccAthenaDataCatalog_type_lambda
=== RUN   TestAccAthenaDataCatalog_type_hive
=== PAUSE TestAccAthenaDataCatalog_type_hive
=== RUN   TestAccAthenaDataCatalog_type_glue
=== PAUSE TestAccAthenaDataCatalog_type_glue
=== RUN   TestAccAthenaDataCatalog_parameters
=== PAUSE TestAccAthenaDataCatalog_parameters
=== CONT  TestAccAthenaDataCatalog_basic
=== CONT  TestAccAthenaDataCatalog_type_hive
=== CONT  TestAccAthenaDataCatalog_parameters
--- PASS: TestAccAthenaDataCatalog_type_hive (19.62s)
=== CONT  TestAccAthenaDataCatalog_type_lambda
--- PASS: TestAccAthenaDataCatalog_basic (19.69s)
=== CONT  TestAccAthenaDataCatalog_type_glue
--- PASS: TestAccAthenaDataCatalog_parameters (31.56s)
=== CONT  TestAccAthenaDataCatalog_tags
--- PASS: TestAccAthenaDataCatalog_type_lambda (17.85s)
--- PASS: TestAccAthenaDataCatalog_type_glue (17.84s)
--- PASS: TestAccAthenaDataCatalog_tags (43.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	79.182s

[github-actions]

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.