-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to register existing IoT certificate #23126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccIoTCertificate_ PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run='TestAccIoTCertificate_' -timeout 180m
=== RUN TestAccIoTCertificate_csr
=== PAUSE TestAccIoTCertificate_csr
=== RUN TestAccIoTCertificate_Keys_certificate
=== PAUSE TestAccIoTCertificate_Keys_certificate
=== RUN TestAccIoTCertificate_Keys_existing_certificate
=== PAUSE TestAccIoTCertificate_Keys_existing_certificate
=== CONT TestAccIoTCertificate_csr
=== CONT TestAccIoTCertificate_Keys_existing_certificate
--- PASS: TestAccIoTCertificate_Keys_existing_certificate (18.93s)
=== CONT TestAccIoTCertificate_Keys_certificate
--- PASS: TestAccIoTCertificate_csr (18.88s)
--- PASS: TestAccIoTCertificate_Keys_certificate (15.02s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 38.919s
@tmarlok88 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This PR adds the ability to register an existing certificate (with or without a CA) in AWS IoT.
Community Note
Output from acceptance testing: