Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_kms_public_key: adds public_key_pem attribute #23130

Merged
merged 4 commits into from
Feb 13, 2022

Conversation

MrGossett
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23115

Output from acceptance testing:

terraform-provider-aws $ make testacc TESTS=TestAccKMSPublicKeyDataSource PKG=kms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20 -run='TestAccKMSPublicKeyDataSource'  -timeout 180m
=== RUN   TestAccKMSPublicKeyDataSource_basic
=== PAUSE TestAccKMSPublicKeyDataSource_basic
=== RUN   TestAccKMSPublicKeyDataSource_encrypt
=== PAUSE TestAccKMSPublicKeyDataSource_encrypt
=== CONT  TestAccKMSPublicKeyDataSource_basic
=== CONT  TestAccKMSPublicKeyDataSource_encrypt
--- PASS: TestAccKMSPublicKeyDataSource_basic (19.06s)
--- PASS: TestAccKMSPublicKeyDataSource_encrypt (19.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kms        20.927s
...

@github-actions github-actions bot added service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Feb 11, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @MrGossett 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 11, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 13, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccKMSPublicKeyDataSource_ PKG=kms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20 -run='TestAccKMSPublicKeyDataSource_'  -timeout 180m
=== RUN   TestAccKMSPublicKeyDataSource_basic
=== PAUSE TestAccKMSPublicKeyDataSource_basic
=== RUN   TestAccKMSPublicKeyDataSource_encrypt
=== PAUSE TestAccKMSPublicKeyDataSource_encrypt
=== CONT  TestAccKMSPublicKeyDataSource_basic
=== CONT  TestAccKMSPublicKeyDataSource_encrypt
--- PASS: TestAccKMSPublicKeyDataSource_encrypt (21.52s)
--- PASS: TestAccKMSPublicKeyDataSource_basic (21.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	25.467s

@ewbankkit
Copy link
Contributor

@MrGossett Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5cb1c66 into hashicorp:main Feb 13, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 13, 2022
@MrGossett MrGossett deleted the f-aws_kms_public_key branch February 13, 2022 23:17
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PEM-encoded attribute for aws_kms_public_key data source
3 participants