-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/datasync_location_object_storage #23154
Conversation
I will not be looking more into this anytime soon, anyone can feel free to take over. |
b4e81f3
to
3112d3e
Compare
07251df
to
a6e0e7b
Compare
@@ -511,6 +516,63 @@ func sweepLocationHDFSs(region string) error { | |||
return nil | |||
} | |||
|
|||
func sweepLocationObjectStorages(region string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: refactor sweeper to new format + reuse one sweeper logic for all locations
@DrFaust92: is this good to go? It looks good to me. |
@YakDriver: can we please get a review here? |
@johnjelinek, good to go |
@ewbankkit: can this one be reviewed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDataSyncLocationObjectStorage_' PKG=datasync ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 3 -run=TestAccDataSyncLocationObjectStorage_ -timeout 180m
=== RUN TestAccDataSyncLocationObjectStorage_basic
=== PAUSE TestAccDataSyncLocationObjectStorage_basic
=== RUN TestAccDataSyncLocationObjectStorage_disappears
=== PAUSE TestAccDataSyncLocationObjectStorage_disappears
=== RUN TestAccDataSyncLocationObjectStorage_tags
=== PAUSE TestAccDataSyncLocationObjectStorage_tags
=== CONT TestAccDataSyncLocationObjectStorage_basic
=== CONT TestAccDataSyncLocationObjectStorage_tags
=== CONT TestAccDataSyncLocationObjectStorage_disappears
--- PASS: TestAccDataSyncLocationObjectStorage_disappears (131.19s)
--- PASS: TestAccDataSyncLocationObjectStorage_basic (134.17s)
--- PASS: TestAccDataSyncLocationObjectStorage_tags (206.48s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datasync 211.659s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22533
Closes #25633
Output from acceptance testing: