Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/datasync_location_object_storage #23154

Merged
merged 17 commits into from
Jan 17, 2023
Merged

r/datasync_location_object_storage #23154

merged 17 commits into from
Jan 17, 2023

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Feb 12, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22533
Closes #25633
Output from acceptance testing:

$ make testacc TESTS=TestAccDataSyncLocationObjectStorage_ PKG=datasync
--- PASS: TestAccDataSyncLocationObjectStorage_disappears (140.47s)
--- PASS: TestAccDataSyncLocationObjectStorage_basic (178.14s)
--- PASS: TestAccDataSyncLocationObjectStorage_tags (253.19s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/datasync Issues and PRs that pertain to the datasync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 12, 2022
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Feb 12, 2022
@DrFaust92 DrFaust92 marked this pull request as draft February 12, 2022 19:05
@DrFaust92
Copy link
Collaborator Author

I will not be looking more into this anytime soon, anyone can feel free to take over.

@DrFaust92 DrFaust92 marked this pull request as ready for review December 24, 2022 21:33
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Dec 24, 2022
DrFaust92
DrFaust92 commented Dec 24, 2022
View reviewed changes
internal/service/datasync/sweep.go
@@ -511,6 +516,63 @@ func sweepLocationHDFSs(region string) error {
return nil
}

func sweepLocationObjectStorages(region string) error {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: refactor sweeper to new format + reuse one sweeper logic for all locations

@johnjelinek johnjelinek mentioned this pull request Jan 13, 2023
Closed
@johnjelinek
Copy link

@DrFaust92: is this good to go? It looks good to me.

@johnjelinek
Copy link

@YakDriver: can we please get a review here?

@DrFaust92
Copy link
Collaborator Author

@johnjelinek, good to go

@johnjelinek
Copy link

@ewbankkit: can this one be reviewed?

ewbankkit
ewbankkit approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSyncLocationObjectStorage_' PKG=datasync ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 3  -run=TestAccDataSyncLocationObjectStorage_ -timeout 180m
=== RUN   TestAccDataSyncLocationObjectStorage_basic
=== PAUSE TestAccDataSyncLocationObjectStorage_basic
=== RUN   TestAccDataSyncLocationObjectStorage_disappears
=== PAUSE TestAccDataSyncLocationObjectStorage_disappears
=== RUN   TestAccDataSyncLocationObjectStorage_tags
=== PAUSE TestAccDataSyncLocationObjectStorage_tags
=== CONT  TestAccDataSyncLocationObjectStorage_basic
=== CONT  TestAccDataSyncLocationObjectStorage_tags
=== CONT  TestAccDataSyncLocationObjectStorage_disappears
--- PASS: TestAccDataSyncLocationObjectStorage_disappears (131.19s)
--- PASS: TestAccDataSyncLocationObjectStorage_basic (134.17s)
--- PASS: TestAccDataSyncLocationObjectStorage_tags (206.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	211.659s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 54f1f25 into hashicorp:main Jan 17, 2023
@github-actions github-actions bot added this to the v4.51.0 milestone Jan 17, 2023
@ewbankkit ewbankkit mentioned this pull request Jan 17, 2023
Merged
@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/datasync Issues and PRs that pertain to the datasync service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.51.0
Development

Successfully merging this pull request may close these issues.

Support Google Cloud Storage as a aws_datasync_location Support for self-managed object storage location
3 participants
@DrFaust92 @johnjelinek @ewbankkit