Handle KMS updates with replica tables.

[grahamhar]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21726

Output from acceptance testing replica related tests:

➜ make testacc  TESTS='TestAccDynamoDBTable_Replica_' PKG=dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_Replica_'  -timeout 180m
=== RUN   TestAccDynamoDBTable_Replica_multiple
=== PAUSE TestAccDynamoDBTable_Replica_multiple
=== RUN   TestAccDynamoDBTable_Replica_single
=== PAUSE TestAccDynamoDBTable_Replica_single
=== RUN   TestAccDynamoDBTable_Replica_singleWithCMK
=== PAUSE TestAccDynamoDBTable_Replica_singleWithCMK
=== RUN   TestAccDynamoDBTable_Replica_singleUpdateToUseCMK
=== PAUSE TestAccDynamoDBTable_Replica_singleUpdateToUseCMK
=== CONT  TestAccDynamoDBTable_Replica_multiple
=== CONT  TestAccDynamoDBTable_Replica_singleWithCMK
=== CONT  TestAccDynamoDBTable_Replica_singleUpdateToUseCMK
=== CONT  TestAccDynamoDBTable_Replica_single
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (342.53s)
--- PASS: TestAccDynamoDBTable_Replica_singleUpdateToUseCMK (459.36s)
--- PASS: TestAccDynamoDBTable_Replica_single (463.40s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (724.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   726.839s

Output from acceptance testing encryption related tests:

➜ make testacc  TESTS='TestAccDynamoDBTable_encryption' PKG=dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_encryption'  -timeout 180m
=== RUN   TestAccDynamoDBTable_encryption
=== PAUSE TestAccDynamoDBTable_encryption
=== CONT  TestAccDynamoDBTable_encryption
--- PASS: TestAccDynamoDBTable_encryption (137.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   139.694s

[pat-humphreys]

Anyone know which release this bug might make it into? v1.1.8?

[grahamhar]

Anyone know which release this bug might make it into? v1.1.8?

@pat-humphreys as I am a community contributor the PRs tend not to get looked at quickly unless there are a large number of reaction on the original message at the top, adding a thumbs up reaction is the best way of helping to get this prioritised

[grahamhar]

@gdavison do I need to do anything to resolve the conflicts on this PR?

[gdavison]

Thanks for the PR, @grahamhar. I've been trying to fix a perpetual diff when the default keys are used (#27850), but that's going to take a lot more work and it isn't worth delaying this PR any longer.

--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (40.05s)
--- PASS: TestAccDynamoDBTable_TTL_enabled (148.44s)
--- PASS: TestAccDynamoDBTable_basic (148.45s)
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (162.16s)
--- PASS: TestAccDynamoDBTable_tags (167.64s)
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (227.47s)
--- PASS: TestAccDynamoDBTable_TTL_disabled (233.44s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (253.67s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (257.70s)
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (14.20s)
--- PASS: TestAccDynamoDBTable_tableClassInfrequentAccess (268.40s)
--- PASS: TestAccDynamoDBTable_encryption (382.82s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (230.33s)
--- PASS: TestAccDynamoDBTable_backup_overrideEncryption (406.05s)
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (429.92s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (236.99s)
--- PASS: TestAccDynamoDBTable_disappears (107.37s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisionedIgnoreChanges (189.85s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (234.46s)
--- PASS: TestAccDynamoDBTable_enablePITR (154.28s)
--- PASS: TestAccDynamoDBTable_Replica_tagsTwoOfTwo (465.41s)
--- PASS: TestAccDynamoDBTable_streamSpecification (168.92s)
--- PASS: TestAccDynamoDBTable_streamSpecificationDiffs (501.32s)
--- PASS: TestAccDynamoDBTable_Replica_tagsOneOfTwo (518.72s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (762.87s)
--- PASS: TestAccDynamoDBTable_Replica_singleAddCMK (786.43s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (558.90s)
--- PASS: TestAccDynamoDBTable_Replica_tagsUpdate (913.00s)
--- PASS: TestAccDynamoDBTable_Replica_single (921.50s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (924.06s)
--- PASS: TestAccDynamoDBTable_Replica_pitr (548.79s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequestIgnoreChanges (736.58s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (1002.36s)
--- PASS: TestAccDynamoDBTable_Replica_tagsNext (912.50s)
--- PASS: TestAccDynamoDBTable_backupEncryption (1145.25s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (1232.55s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (1086.53s)
--- PASS: TestAccDynamoDBTable_extended (615.45s)

[github-actions]

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.