-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_eks_addon_version #23157
d/aws_eks_addon_version #23157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @charlesakalugwu 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
744e7e3
to
2ced1d0
Compare
2ced1d0
to
aa23e01
Compare
aa23e01
to
5063b45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a wonderful first PR! Really well done!
I have included some feedback on user expectations when workign with data sources.
@justinretzolk or @ewbankkit might have more feedback?
628953a
to
fc3cc07
Compare
fc3cc07
to
76a446c
Compare
@AdamTylerLynch / @drewmullen any additional feedback on this one to get it across the line? Thanks for the PR @charlesakalugwu ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccEKSAddonVersionDataSource_ PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSAddonVersionDataSource_' -timeout 180m
=== RUN TestAccEKSAddonVersionDataSource_basic
=== PAUSE TestAccEKSAddonVersionDataSource_basic
=== CONT TestAccEKSAddonVersionDataSource_basic
--- PASS: TestAccEKSAddonVersionDataSource_basic (768.42s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 772.130s
@charlesakalugwu Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This is my first contribution - feedback is very much welcome.
Thank you!
Community Note
Closes #20725
Release note for CHANGELOG
Output from acceptance testing:
References