Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_eks_addon_version #23157

Merged

Conversation

charlesakalugwu
Copy link
Contributor

@charlesakalugwu charlesakalugwu commented Feb 13, 2022

This is my first contribution - feedback is very much welcome.

Thank you!

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20725

Release note for CHANGELOG

data-source/aws_eks_addon_version: new data-source

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccEKSAddonVersion*' ACCTEST_PARALLELISM=5 PKG=eks                                            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 5  -run=TestAccEKSAddonVersion* -timeout 180m
=== RUN   TestAccEKSAddonVersionDataSource_basic
=== PAUSE TestAccEKSAddonVersionDataSource_basic
=== CONT  TestAccEKSAddonVersionDataSource_basic
--- PASS: TestAccEKSAddonVersionDataSource_basic (900.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        904.984s

References

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Feb 13, 2022
@charlesakalugwu charlesakalugwu changed the title Add eks addon version data source d/aws_eks_addon_version Feb 13, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @charlesakalugwu 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@charlesakalugwu charlesakalugwu force-pushed the f-aws_eks_addon_version_data_source branch from 744e7e3 to 2ced1d0 Compare February 15, 2022 18:03
@charlesakalugwu charlesakalugwu marked this pull request as ready for review February 15, 2022 18:17
@charlesakalugwu charlesakalugwu force-pushed the f-aws_eks_addon_version_data_source branch from 2ced1d0 to aa23e01 Compare February 15, 2022 19:23
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 15, 2022
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a wonderful first PR! Really well done!

I have included some feedback on user expectations when workign with data sources.

@justinretzolk or @ewbankkit might have more feedback?

internal/service/eks/find.go Outdated Show resolved Hide resolved
internal/service/eks/addon_version_data_source.go Outdated Show resolved Hide resolved
internal/service/eks/find.go Outdated Show resolved Hide resolved
@charlesakalugwu charlesakalugwu force-pushed the f-aws_eks_addon_version_data_source branch 2 times, most recently from 628953a to fc3cc07 Compare February 17, 2022 04:05
@charlesakalugwu charlesakalugwu force-pushed the f-aws_eks_addon_version_data_source branch from fc3cc07 to 76a446c Compare February 17, 2022 21:54
@bryantbiggs
Copy link
Contributor

@AdamTylerLynch / @drewmullen any additional feedback on this one to get it across the line? Thanks for the PR @charlesakalugwu !

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccEKSAddonVersionDataSource_ PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSAddonVersionDataSource_'  -timeout 180m
=== RUN   TestAccEKSAddonVersionDataSource_basic
=== PAUSE TestAccEKSAddonVersionDataSource_basic
=== CONT  TestAccEKSAddonVersionDataSource_basic
--- PASS: TestAccEKSAddonVersionDataSource_basic (768.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	772.130s

@ewbankkit
Copy link
Contributor

@charlesakalugwu Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6e6e4be into hashicorp:main Apr 4, 2022
@github-actions github-actions bot added this to the v4.9.0 milestone Apr 4, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support aws_eks_addon_version data source
6 participants