Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/iam_signing_certificate #23161

Merged
merged 5 commits into from
Feb 13, 2022
Merged

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Feb 13, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccSigningCertificate_ PKG=iam

--- PASS: TestAccSigningCertificate_disappears (40.98s)
--- PASS: TestAccSigningCertificate_basic (47.19s)
--- PASS: TestAccSigningCertificate_status (103.17s)
$ make testacc TESTS=TestAccIAMUser_ForceDestroy_signingCertificate PKG=iam

--- PASS: TestAccIAMUser_ForceDestroy_signingCertificate (46.92s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Feb 13, 2022
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Feb 13, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. sweeper Pertains to changes to or issues with the sweeper. and removed sweeper Pertains to changes to or issues with the sweeper. labels Feb 13, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review February 13, 2022 17:09
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccSigningCertificate_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccSigningCertificate_'  -timeout 180m
=== RUN   TestAccSigningCertificate_basic
=== PAUSE TestAccSigningCertificate_basic
=== RUN   TestAccSigningCertificate_status
=== PAUSE TestAccSigningCertificate_status
=== RUN   TestAccSigningCertificate_disappears
=== PAUSE TestAccSigningCertificate_disappears
=== CONT  TestAccSigningCertificate_basic
=== CONT  TestAccSigningCertificate_disappears
=== CONT  TestAccSigningCertificate_status
--- PASS: TestAccSigningCertificate_disappears (18.87s)
--- PASS: TestAccSigningCertificate_basic (21.74s)
--- PASS: TestAccSigningCertificate_status (49.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	53.481s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ac0a1be into hashicorp:main Feb 13, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 13, 2022
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
@DrFaust92 DrFaust92 deleted the iam_signing_cert branch May 21, 2022 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants