Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cutom vpc for app runner #23173

Merged
merged 10 commits into from
Mar 3, 2022

Conversation

Yoshiitaka
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23090

Output from acceptance testing:

❯ make testacc TESTS=TestAccAppRunnerVpcConnector_ PKG=apprunner          

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run='TestAccAppRunnerVpcConnector_'  -timeout 180m
=== RUN   TestAccAppRunnerVpcConnector_basic
=== PAUSE TestAccAppRunnerVpcConnector_basic
=== RUN   TestAccAppRunnerVpcConnector_disappears
=== PAUSE TestAccAppRunnerVpcConnector_disappears
=== RUN   TestAccAppRunnerVpcConnector_tags
=== PAUSE TestAccAppRunnerVpcConnector_tags
=== CONT  TestAccAppRunnerVpcConnector_basic
=== CONT  TestAccAppRunnerVpcConnector_tags
=== CONT  TestAccAppRunnerVpcConnector_disappears
--- PASS: TestAccAppRunnerVpcConnector_disappears (47.37s)
--- PASS: TestAccAppRunnerVpcConnector_basic (56.51s)
--- PASS: TestAccAppRunnerVpcConnector_tags (56.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner 

...

Co-authored-by: Synohara <jyoniums@gmail.com>
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apprunner Issues and PRs that pertain to the apprunner service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 14, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 14, 2022
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Mar 3, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAppRunnerVpcConnector_ PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run='TestAccAppRunnerVpcConnector_'  -timeout 180m
=== RUN   TestAccAppRunnerVpcConnector_basic
=== PAUSE TestAccAppRunnerVpcConnector_basic
=== RUN   TestAccAppRunnerVpcConnector_disappears
=== PAUSE TestAccAppRunnerVpcConnector_disappears
=== RUN   TestAccAppRunnerVpcConnector_tags
=== PAUSE TestAccAppRunnerVpcConnector_tags
=== CONT  TestAccAppRunnerVpcConnector_basic
=== CONT  TestAccAppRunnerVpcConnector_tags
=== CONT  TestAccAppRunnerVpcConnector_disappears
--- PASS: TestAccAppRunnerVpcConnector_disappears (46.70s)
--- PASS: TestAccAppRunnerVpcConnector_tags (51.90s)
--- PASS: TestAccAppRunnerVpcConnector_basic (52.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	56.765s
% make testacc TESTARGS='-run=TestAccAppRunnerService_ImageRepository_basic\|TestAccAppRunnerService_ImageRepository_networkConfiguration' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunnerService_ImageRepository_basic\|TestAccAppRunnerService_ImageRepository_networkConfiguration -timeout 180m
=== RUN   TestAccAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAppRunnerService_ImageRepository_basic
=== RUN   TestAccAppRunnerService_ImageRepository_networkConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_networkConfiguration
=== CONT  TestAccAppRunnerService_ImageRepository_basic
=== CONT  TestAccAppRunnerService_ImageRepository_networkConfiguration
--- PASS: TestAccAppRunnerService_ImageRepository_basic (272.17s)
--- PASS: TestAccAppRunnerService_ImageRepository_networkConfiguration (507.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	511.538s

@ewbankkit
Copy link
Contributor

@Yoshiitaka Thanks for the contribution 🎉 👏.
I made the network_configuration block in the aws_apprunner_service Computed as it is populated with egress_type = "DEFAULT" for non-VPC-attached services.

@ewbankkit ewbankkit merged commit e20e1c5 into hashicorp:main Mar 3, 2022
@github-actions github-actions bot added this to the v4.4.0 milestone Mar 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/apprunner Issues and PRs that pertain to the apprunner service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for App Runner VPC Connectors
4 participants