Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_source/aws_vpc_ipam_pool: Add filter examples to docs, add error if no pool found #23195

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

drewmullen
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #23194

Output from acceptance testing:

$ make testacc TESTS=TestAccDataSourceVPCIpamPool_basic PKG=ec2  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccDataSourceVPCIpamPool_basic'  -timeout 180m
=== RUN   TestAccDataSourceVPCIpamPool_basic
=== PAUSE TestAccDataSourceVPCIpamPool_basic
=== CONT  TestAccDataSourceVPCIpamPool_basic
--- PASS: TestAccDataSourceVPCIpamPool_basic (51.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        56.780s
...

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 15, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccDataSourceVPCIpamPool_ PKG=ec2  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccDataSourceVPCIpamPool_'  -timeout 180m
=== RUN   TestAccDataSourceVPCIpamPool_basic
=== PAUSE TestAccDataSourceVPCIpamPool_basic
=== CONT  TestAccDataSourceVPCIpamPool_basic
--- PASS: TestAccDataSourceVPCIpamPool_basic (48.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	55.935s

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@drewmullen
Copy link
Collaborator Author

thanks @ewbankkit I was planning to push that last commit this morning! appreciate you closing it out for me

@ewbankkit ewbankkit merged commit d176fba into hashicorp:main Feb 15, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 15, 2022
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data.aws_vpc_ipam_pool should fail if no pools found
3 participants