Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_iam_openid_connect_provider #23240

Merged
merged 10 commits into from
Feb 17, 2022
Merged

d/aws_iam_openid_connect_provider #23240

merged 10 commits into from
Feb 17, 2022

Conversation

abebars
Copy link
Contributor

@abebars abebars commented Feb 17, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17747

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccIAMOpenidConnectProviderDataSource_' PKG=iam ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 1  -run=TestAccIAMOpenidConnectProviderDataSource_ -timeout 180m
=== RUN   TestAccIAMOpenidConnectProviderDataSource_basic
=== PAUSE TestAccIAMOpenidConnectProviderDataSource_basic
=== RUN   TestAccIAMOpenidConnectProviderDataSource_url
=== PAUSE TestAccIAMOpenidConnectProviderDataSource_url
=== RUN   TestAccIAMOpenidConnectProviderDataSource_tags
=== PAUSE TestAccIAMOpenidConnectProviderDataSource_tags
=== CONT  TestAccIAMOpenidConnectProviderDataSource_basic
--- PASS: TestAccIAMOpenidConnectProviderDataSource_basic (34.77s)
=== CONT  TestAccIAMOpenidConnectProviderDataSource_tags
--- PASS: TestAccIAMOpenidConnectProviderDataSource_tags (35.79s)
=== CONT  TestAccIAMOpenidConnectProviderDataSource_url
--- PASS: TestAccIAMOpenidConnectProviderDataSource_url (69.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        143.095s
...

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 17, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 17, 2022
@abebars abebars mentioned this pull request Feb 17, 2022
Closed
@abebars abebars force-pushed the f-aws-iam-oidc-datasource branch from 0b2d16e to 983f27e Compare February 17, 2022 04:20
@abebars abebars force-pushed the f-aws-iam-oidc-datasource branch from 983f27e to d71a2fd Compare February 17, 2022 04:24
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 17, 2022
ewbankkit
ewbankkit approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIAMOpenidConnectProviderDataSource_' PKG=iam                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20  -run=TestAccIAMOpenidConnectProviderDataSource_ -timeout 180m
=== RUN   TestAccIAMOpenidConnectProviderDataSource_basic
=== PAUSE TestAccIAMOpenidConnectProviderDataSource_basic
=== RUN   TestAccIAMOpenidConnectProviderDataSource_url
=== PAUSE TestAccIAMOpenidConnectProviderDataSource_url
=== RUN   TestAccIAMOpenidConnectProviderDataSource_tags
=== PAUSE TestAccIAMOpenidConnectProviderDataSource_tags
=== CONT  TestAccIAMOpenidConnectProviderDataSource_basic
=== CONT  TestAccIAMOpenidConnectProviderDataSource_tags
=== CONT  TestAccIAMOpenidConnectProviderDataSource_url
--- PASS: TestAccIAMOpenidConnectProviderDataSource_basic (19.77s)
--- PASS: TestAccIAMOpenidConnectProviderDataSource_tags (19.84s)
--- PASS: TestAccIAMOpenidConnectProviderDataSource_url (32.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	38.107s

@ewbankkit
Copy link
Contributor

@abebars Thanks for the contribution 🎉 👏.

@abebars
Copy link
Contributor Author

abebars commented Feb 17, 2022

@ewbankkit Thanks for reviewing it so quickly

@ewbankkit ewbankkit merged commit d27dae3 into hashicorp:main Feb 17, 2022
@github-actions github-actions bot added this to the v4.2.0 milestone Feb 17, 2022
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@abebars abebars deleted the f-aws-iam-oidc-datasource branch February 22, 2022 05:19
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.

Support aws_iam_openid_connect_provider as data resource
2 participants
@abebars @ewbankkit