-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/elasticache_replication_group: prevent empty strings in resource description #23254
Conversation
23a26b8
to
cbf15ae
Compare
2ae6b3a
to
f85b75f
Compare
f85b75f
to
4be507f
Compare
4be507f
to
66b8deb
Compare
66b8deb
to
120198b
Compare
120198b
to
274b923
Compare
274b923
to
d06c40e
Compare
d06c40e
to
bc8b3b1
Compare
bc8b3b1
to
b2df803
Compare
b2df803
to
1f1781c
Compare
1f1781c
to
3a0b078
Compare
@gdavison in v4 , one of the descriptions is required but we don't enforce non-empty strings. i've done so here but am not sure if that is technically correct when the API technically accepts an empty string 🤔 what's your thought on the linked issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MPB! 🎉
but, whitespaces...
3a0b078
to
b00d810
Compare
This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #23220
Output from acceptance testing: