d/glue_catalog_table

[chris922]

This is my first contribution, hope I did everything as expected. If not please let me know :)

I added a data source for a glue catalog table and more or less copied and adapted many things from the regular resource. I was unsure if it is desired to have one generic "read" function and use this one in the resource and data source, but for simplicity, I now started with separate functions as for other resources it looks similar.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccGlueDataCatalogDataSource*' ACCTEST_PARALLELISM=5 PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 5  -run=TestAccGlueDataCatalogDataSource* -timeout 180m
=== RUN   TestAccGlueDataCatalogDataSource_basic
=== PAUSE TestAccGlueDataCatalogDataSource_basic
=== CONT  TestAccGlueDataCatalogDataSource_basic
--- PASS: TestAccGlueDataCatalogDataSource_basic (29.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       29.790s
...

[github-actions]

Welcome @chris922 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[bschaatsbergen]

Hi @chris922, thanks for raising this pull request. I've noted it down to review this in the coming days.

[bschaatsbergen]

Thanks for your contribution @chris922 , overall it looks good to m. I've used the data source and ran the tests on your fork - which seemed 👍 .

bruno@bruno ~/g/f/chris992-terraform-provider-aws (feature/glue-data-catalog-table-datasource)> make testacc TESTARGS='-run=TestAccGlueDataCatalogDataSource*' ACCTEST_PARALLELISM=5 PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 5  -run=TestAccGlueDataCatalogDataSource* -timeout 180m
=== RUN   TestAccGlueDataCatalogDataSource_basic
=== PAUSE TestAccGlueDataCatalogDataSource_basic
=== CONT  TestAccGlueDataCatalogDataSource_basic
--- PASS: TestAccGlueDataCatalogDataSource_basic (26.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       28.114s

If you could address the few comments we can get this 🚢 shipped!

[chris922]

Thanks @bschaatsbergen for the review! Please have a look at my changes and resolve the threads if they match your expectation. If you prefer to squash the commits in advance let me know so that I can rebase it.

[chris922]

Hmm, I squashed and rebased it... but the pipeline still fails, any ideas?

[chris922]

@bschaatsbergen : I rebased my changes onto the main and it looks better for now

[bschaatsbergen]

@ewbankkit would you mind checking this PR out :) ?

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGlueCatalogTableDataSource_' PKG=glue ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 2  -run=TestAccGlueCatalogTableDataSource_ -timeout 180m
=== RUN   TestAccGlueCatalogTableDataSource_basic
=== PAUSE TestAccGlueCatalogTableDataSource_basic
=== CONT  TestAccGlueCatalogTableDataSource_basic
--- PASS: TestAccGlueCatalogTableDataSource_basic (17.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	23.130s

[ewbankkit]

@chris922 Thanks for the contribution 🎉 👏.
In general everything looks great.
I had to tweak a few function names to match changes made since the PR was originally created.

[bschaatsbergen]

Nice work @chris922 !

[github-actions]

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[chris922]

Great, thanks a lot!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.