Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds/opsworks: Fix bugs, tests; add opsworks sweepers #23397

Merged
merged 17 commits into from
Mar 1, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 26, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

% make testacc TESTS=TestAccOpsWorks PKG=opsworks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opsworks/... -v -count 1 -parallel 20 -run='TestAccOpsWorks'  -timeout 180m
--- PASS: TestAccOpsWorksStack_classicEndpoints (84.92s)
--- PASS: TestAccOpsWorksGangliaLayer_basic (48.45s)
--- PASS: TestAccOpsWorksUserProfile_basic (50.20s)
--- PASS: TestAccOpsWorksHAProxyLayer_basic (60.06s)
--- PASS: TestAccOpsWorksNodejsAppLayer_basic (67.10s)
--- PASS: TestAccOpsWorksStack_noVPCCreateTags (69.58s)
--- PASS: TestAccOpsWorksJavaAppLayer_basic (74.76s)
--- PASS: TestAccOpsWorksPermission_self (76.21s)
--- PASS: TestAccOpsWorksRailsAppLayer_basic (86.47s)
--- PASS: TestAccOpsWorksInstance_updateHostNameForceNew (100.01s)
--- PASS: TestAccOpsWorksGangliaLayer_tags (101.77s)
--- PASS: TestAccOpsWorksStaticWebLayer_basic (52.51s)
--- PASS: TestAccOpsWorksApplication_basic (111.30s)
--- PASS: TestAccOpsWorksHAProxyLayer_tags (116.36s)
--- PASS: TestAccOpsWorksECSClusterLayer_tags (118.93s)
--- PASS: TestAccOpsWorksMemcachedLayer_basic (54.32s)
--- PASS: TestAccOpsWorksInstance_basic (126.23s)
--- PASS: TestAccOpsWorksStaticWebLayer_tags (127.54s)
--- PASS: TestAccOpsWorksPHPAppLayer_tags (130.35s)
--- PASS: TestAccOpsWorksNodejsAppLayer_tags (135.40s)
--- PASS: TestAccOpsWorksPHPAppLayer_basic (139.95s)
--- PASS: TestAccOpsWorksECSClusterLayer_basic (35.26s)
--- PASS: TestAccOpsWorksStack_CustomCookbooks_setPrivateProperties (91.81s)
--- PASS: TestAccOpsWorksMySQLLayer_tags (100.90s)
--- PASS: TestAccOpsWorksStack_noVPCBasic (61.94s)
--- PASS: TestAccOpsWorksRailsAppLayer_tags (163.31s)
--- PASS: TestAccOpsWorksCustomLayer_disappears (46.36s)
--- PASS: TestAccOpsWorksCustomLayer_basic (38.17s)
--- PASS: TestAccOpsWorksMemcachedLayer_tags (92.83s)
--- PASS: TestAccOpsWorksJavaAppLayer_tags (95.66s)
--- PASS: TestAccOpsWorksStack_noVPCChangeServiceRoleForceNew (74.26s)
--- PASS: TestAccOpsWorksStack_vpc (103.18s)
--- PASS: TestAccOpsWorksPermission_basic (199.39s)
--- PASS: TestAccOpsWorksCustomLayer_cloudwatch (128.84s)
--- PASS: TestAccOpsWorksCustomLayer_noVPC (108.37s)
--- PASS: TestAccOpsWorksCustomLayer_tags (125.42s)
--- PASS: TestAccOpsWorksMySQLLayer_basic (219.87s)
--- PASS: TestAccOpsWorksRDSDBInstance_basic (817.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opsworks	1030.176s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. service/opsworks Issues and PRs that pertain to the opsworks service. service/rds Issues and PRs that pertain to the rds service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 26, 2022
@YakDriver YakDriver changed the title t opsworks rds tests sweepers rds/opsworks: Fix bugs, tests; add opsworks sweepers Feb 26, 2022
@YakDriver YakDriver marked this pull request as draft February 26, 2022 02:46
@YakDriver YakDriver force-pushed the t-opsworks-rds-tests-sweepers branch 2 times, most recently from 89948ce to 1616462 Compare February 28, 2022 18:42
@YakDriver YakDriver force-pushed the t-opsworks-rds-tests-sweepers branch from 1616462 to ffab2a4 Compare March 1, 2022 01:04
@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label Mar 1, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 1, 2022
@YakDriver YakDriver marked this pull request as ready for review March 1, 2022 18:02
@YakDriver YakDriver merged commit cf90a18 into main Mar 1, 2022
@YakDriver YakDriver deleted the t-opsworks-rds-tests-sweepers branch March 1, 2022 18:06
@github-actions github-actions bot added this to the v4.4.0 milestone Mar 1, 2022
github-actions bot pushed a commit that referenced this pull request Mar 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. service/opsworks Issues and PRs that pertain to the opsworks service. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant