Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NotImplemented error handling in GetBucketLogging #23398

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

wilfriedroset
Copy link
Contributor

Relates to #23278

Signed-off-by: Wilfried Roset wilfriedroset@users.noreply.github.com

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

Relates to hashicorp#23278

Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Feb 26, 2022
@anGie44 anGie44 changed the title Add XNotEmplemented error handling in GetBucketLogging Add NotImplemented error handling in GetBucketLogging Feb 28, 2022
@anGie44 anGie44 changed the title Add NotImplemented error handling in GetBucketLogging Add NotImplemented error handling in GetBucketLogging Feb 28, 2022
@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 28, 2022
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wilfriedroset , thank for this PR! LGTM, just needs a changelog entry similar to https://github.com/hashicorp/terraform-provider-aws/pull/23278/files#diff-23ea4248c5cb3058602beb42f60b4b74fb6c34738fffa2723ccef4000be6fd9c . I'll go ahead and do so 👍

@anGie44 anGie44 added this to the v4.3.0 milestone Feb 28, 2022
@anGie44
Copy link
Contributor

anGie44 commented Feb 28, 2022

Note: Ignoring schema CI failure as unrelated to these changes.

@anGie44 anGie44 merged commit cc2ccee into hashicorp:main Feb 28, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants