Add support for AWS Secrets Manager when creating DMS endpoints for aurora-postgresql engine

[paulmesser10x]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

terraform -v
Terraform v1.1.6
on darwin_amd64

• provider registry.terraform.io/hashicorp/aws v3.74.3 (also not supported yet on 4.3.0)

Affected Resource(s)

• aws_dms_endpoint

Terraform Configuration Files

terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "~> 3.0"
    }
  }
}

# Configure the AWS Provider
provider "aws" {
  region = "eu-west-1"
}

resource "aws_dms_endpoint" "this" {
  database_name                   = "postgres"
  endpoint_id                     = "db6-test-tf"
  endpoint_type                   = "source"
  engine_name                     = "aurora-postgresql"
  secrets_manager_arn             = "arn:aws:secretsmanager:eu-west-1:<ACCOUNTID>:secret:<SECRETNAME>"
  secrets_manager_access_role_arn = "arn:aws:iam::<ACCOUNTID>:role/<ROLENAME>"
}

Debug Output

N/A

Panic Output

N/A

Expected Behavior

Would like support for engine aurora-postgresql

Actual Behavior

Behaves according to the documentation: According to the provider documentation, use of the secrets_manager_arn optional parameter is only supported only for engine_name as oracle and postgres.

Steps to Reproduce

1. terraform apply

Important Factoids

References

AWS DMS supports a PostgreSQL version 9.4 and later (for versions 9.x), 10.x, 11.x, 12.x, and 13.x database as a source for these types of databases:

1. On-premises databases
2. Databases on an Amazon EC2 instance
3. Databases on an Amazon RDS DB instance
4. Databases on an DB instance based on Amazon Aurora PostgreSQL-Compatible Edition

[+] Using a PostgreSQL database as an AWS DMS source :
https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Source.PostgreSQL.html

[jpatel1985]

This is a must-needed feature. Upvote.

[jpatel1985]

👍

[github-actions]

This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.