r/aws_ec2_network_insights_analysis - new resource

[george-richardson]

Adds a new resource aws_ec2_network_insights_analysis.

This is a minimal useful implementation that can be used to get a boolean result of the analysis. Much more information is accessible in the API, but I'm not sure how to translate to the Terraform schema as there are a lot of nested objects. If someone can give me some pointers here, I would be happy to open another PR adding more attributes.

Example config:

resource "aws_ec2_network_insights_path" "path" {
  source      = aws_network_interface.source.id
  destination = aws_network_interface.destination.id
  protocol    = "tcp"
}
resource "aws_ec2_network_insights_analysis" "analysis" {
  network_insights_path_id = aws_ec2_network_insights_path.path.id
}

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16715.

Output from acceptance testing:

$ make testacc TESTS=TestAccNetworkInsightsAnalysis PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 1 -run='TestAccNetworkInsightsAnalysis'  -timeout 180m
=== RUN   TestAccNetworkInsightsAnalysis_basic
=== PAUSE TestAccNetworkInsightsAnalysis_basic
=== RUN   TestAccNetworkInsightsAnalysis_disappears
=== PAUSE TestAccNetworkInsightsAnalysis_disappears
=== RUN   TestAccNetworkInsightsAnalysis_tags
=== PAUSE TestAccNetworkInsightsAnalysis_tags
=== RUN   TestAccNetworkInsightsAnalysis_filterInARNs
=== PAUSE TestAccNetworkInsightsAnalysis_filterInARNs
=== RUN   TestAccNetworkInsightsAnalysis_waitForCompletion
=== PAUSE TestAccNetworkInsightsAnalysis_waitForCompletion
=== CONT  TestAccNetworkInsightsAnalysis_basic
--- PASS: TestAccNetworkInsightsAnalysis_basic (55.53s)
=== CONT  TestAccNetworkInsightsAnalysis_filterInARNs
--- PASS: TestAccNetworkInsightsAnalysis_filterInARNs (101.12s)
=== CONT  TestAccNetworkInsightsAnalysis_waitForCompletion
--- PASS: TestAccNetworkInsightsAnalysis_waitForCompletion (46.31s)
=== CONT  TestAccNetworkInsightsAnalysis_tags
--- PASS: TestAccNetworkInsightsAnalysis_tags (89.93s)
=== CONT  TestAccNetworkInsightsAnalysis_disappears
--- PASS: TestAccNetworkInsightsAnalysis_disappears (50.93s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        345.776s

(reduced parallelism because I was hitting VPC limits in my test account)

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCNetworkInsightsAnalysis' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCNetworkInsightsAnalysis -timeout 180m
=== RUN   TestAccVPCNetworkInsightsAnalysisDataSource_basic
=== PAUSE TestAccVPCNetworkInsightsAnalysisDataSource_basic
=== RUN   TestAccVPCNetworkInsightsAnalysis_basic
=== PAUSE TestAccVPCNetworkInsightsAnalysis_basic
=== RUN   TestAccVPCNetworkInsightsAnalysis_disappears
=== PAUSE TestAccVPCNetworkInsightsAnalysis_disappears
=== RUN   TestAccVPCNetworkInsightsAnalysis_tags
=== PAUSE TestAccVPCNetworkInsightsAnalysis_tags
=== RUN   TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== PAUSE TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== RUN   TestAccVPCNetworkInsightsAnalysis_waitForCompletion
=== PAUSE TestAccVPCNetworkInsightsAnalysis_waitForCompletion
=== CONT  TestAccVPCNetworkInsightsAnalysisDataSource_basic
=== CONT  TestAccVPCNetworkInsightsAnalysis_tags
--- PASS: TestAccVPCNetworkInsightsAnalysisDataSource_basic (51.00s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_waitForCompletion
--- PASS: TestAccVPCNetworkInsightsAnalysis_tags (85.14s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_filterInARNs
--- PASS: TestAccVPCNetworkInsightsAnalysis_waitForCompletion (45.97s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_disappears
--- PASS: TestAccVPCNetworkInsightsAnalysis_disappears (47.93s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_basic
--- PASS: TestAccVPCNetworkInsightsAnalysis_filterInARNs (93.61s)
--- PASS: TestAccVPCNetworkInsightsAnalysis_basic (53.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	202.369s
% make testacc TESTARGS='-run=TestAccVPCNetworkInsightsPath' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCNetworkInsightsPath -timeout 180m
=== RUN   TestAccVPCNetworkInsightsPathDataSource_basic
=== PAUSE TestAccVPCNetworkInsightsPathDataSource_basic
=== RUN   TestAccVPCNetworkInsightsPath_basic
=== PAUSE TestAccVPCNetworkInsightsPath_basic
=== RUN   TestAccVPCNetworkInsightsPath_disappears
=== PAUSE TestAccVPCNetworkInsightsPath_disappears
=== RUN   TestAccVPCNetworkInsightsPath_tags
=== PAUSE TestAccVPCNetworkInsightsPath_tags
=== RUN   TestAccVPCNetworkInsightsPath_sourceIP
=== PAUSE TestAccVPCNetworkInsightsPath_sourceIP
=== RUN   TestAccVPCNetworkInsightsPath_destinationIP
=== PAUSE TestAccVPCNetworkInsightsPath_destinationIP
=== RUN   TestAccVPCNetworkInsightsPath_destinationPort
=== PAUSE TestAccVPCNetworkInsightsPath_destinationPort
=== CONT  TestAccVPCNetworkInsightsPathDataSource_basic
=== CONT  TestAccVPCNetworkInsightsPath_sourceIP
--- PASS: TestAccVPCNetworkInsightsPathDataSource_basic (22.16s)
=== CONT  TestAccVPCNetworkInsightsPath_destinationPort
--- PASS: TestAccVPCNetworkInsightsPath_sourceIP (39.05s)
=== CONT  TestAccVPCNetworkInsightsPath_destinationIP
--- PASS: TestAccVPCNetworkInsightsPath_destinationPort (39.46s)
=== CONT  TestAccVPCNetworkInsightsPath_disappears
--- PASS: TestAccVPCNetworkInsightsPath_destinationIP (39.54s)
=== CONT  TestAccVPCNetworkInsightsPath_tags
--- PASS: TestAccVPCNetworkInsightsPath_disappears (21.01s)
=== CONT  TestAccVPCNetworkInsightsPath_basic
--- PASS: TestAccVPCNetworkInsightsPath_basic (23.00s)
--- PASS: TestAccVPCNetworkInsightsPath_tags (53.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	135.938s

[ewbankkit]

@george-richardson Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.