-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_mskconnect_connector resource #23544
Conversation
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @gungoren 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Acceptance test output: % make testacc TESTS=TestAccKafkaConnectCustomPlugin_ PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectCustomPlugin_' -timeout 180m === RUN TestAccKafkaConnectCustomPlugin_basic === PAUSE TestAccKafkaConnectCustomPlugin_basic === RUN TestAccKafkaConnectCustomPlugin_description === PAUSE TestAccKafkaConnectCustomPlugin_description === RUN TestAccKafkaConnectCustomPlugin_contentType === PAUSE TestAccKafkaConnectCustomPlugin_contentType === RUN TestAccKafkaConnectCustomPlugin_objectVersion === PAUSE TestAccKafkaConnectCustomPlugin_objectVersion === CONT TestAccKafkaConnectCustomPlugin_basic === CONT TestAccKafkaConnectCustomPlugin_contentType --- PASS: TestAccKafkaConnectCustomPlugin_basic (41.38s) === CONT TestAccKafkaConnectCustomPlugin_description --- PASS: TestAccKafkaConnectCustomPlugin_contentType (68.96s) === CONT TestAccKafkaConnectCustomPlugin_objectVersion --- PASS: TestAccKafkaConnectCustomPlugin_description (29.53s) --- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (29.79s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 102.677s
…ions. Acceptance test output: % make testacc TESTS=TestAccKafkaConnectCustomPlugin PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectCustomPlugin' -timeout 180m === RUN TestAccKafkaConnectCustomPluginDataSource_basic === PAUSE TestAccKafkaConnectCustomPluginDataSource_basic === RUN TestAccKafkaConnectCustomPlugin_basic === PAUSE TestAccKafkaConnectCustomPlugin_basic === RUN TestAccKafkaConnectCustomPlugin_description === PAUSE TestAccKafkaConnectCustomPlugin_description === RUN TestAccKafkaConnectCustomPlugin_objectVersion === PAUSE TestAccKafkaConnectCustomPlugin_objectVersion === CONT TestAccKafkaConnectCustomPluginDataSource_basic === CONT TestAccKafkaConnectCustomPlugin_description --- PASS: TestAccKafkaConnectCustomPluginDataSource_basic (87.75s) === CONT TestAccKafkaConnectCustomPlugin_objectVersion --- PASS: TestAccKafkaConnectCustomPlugin_description (89.30s) === CONT TestAccKafkaConnectCustomPlugin_basic --- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (47.41s) --- PASS: TestAccKafkaConnectCustomPlugin_basic (47.08s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 142.592s
Acceptance test output: % AWS_DEFAULT_REGION=us-east-1 make testacc TESTS=TestAccKafkaConnectConnector_ PKG=kafkaconnect ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run='TestAccKafkaConnectConnector_' -timeout 180m === RUN TestAccKafkaConnectConnector_basic === PAUSE TestAccKafkaConnectConnector_basic === CONT TestAccKafkaConnectConnector_basic --- PASS: TestAccKafkaConnectConnector_basic (1877.87s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 1881.927s
…disappears'. Acceptance test output: % make testacc TESTS=TestAccKafkaConnectCustomPlugin PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectCustomPlugin' -timeout 180m === RUN TestAccKafkaConnectCustomPluginDataSource_basic === PAUSE TestAccKafkaConnectCustomPluginDataSource_basic === RUN TestAccKafkaConnectCustomPlugin_basic === PAUSE TestAccKafkaConnectCustomPlugin_basic === RUN TestAccKafkaConnectCustomPlugin_disappears === PAUSE TestAccKafkaConnectCustomPlugin_disappears === RUN TestAccKafkaConnectCustomPlugin_description === PAUSE TestAccKafkaConnectCustomPlugin_description === RUN TestAccKafkaConnectCustomPlugin_objectVersion === PAUSE TestAccKafkaConnectCustomPlugin_objectVersion === CONT TestAccKafkaConnectCustomPluginDataSource_basic === CONT TestAccKafkaConnectCustomPlugin_description --- PASS: TestAccKafkaConnectCustomPluginDataSource_basic (42.15s) === CONT TestAccKafkaConnectCustomPlugin_disappears --- PASS: TestAccKafkaConnectCustomPlugin_description (49.43s) === CONT TestAccKafkaConnectCustomPlugin_basic --- PASS: TestAccKafkaConnectCustomPlugin_disappears (41.17s) === CONT TestAccKafkaConnectCustomPlugin_objectVersion --- PASS: TestAccKafkaConnectCustomPlugin_basic (41.36s) --- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (40.76s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 128.293s
…RUD handler signatures (#15090). Acceptance test output: % make testacc TESTS=TestAccKafkaConnectWorkerConfiguration PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectWorkerConfiguration' -timeout 180m === RUN TestAccKafkaConnectWorkerConfigurationDataSource_basic === PAUSE TestAccKafkaConnectWorkerConfigurationDataSource_basic === RUN TestAccKafkaConnectWorkerConfiguration_basic === PAUSE TestAccKafkaConnectWorkerConfiguration_basic === RUN TestAccKafkaConnectWorkerConfiguration_description === PAUSE TestAccKafkaConnectWorkerConfiguration_description === CONT TestAccKafkaConnectWorkerConfigurationDataSource_basic === CONT TestAccKafkaConnectWorkerConfiguration_description --- PASS: TestAccKafkaConnectWorkerConfiguration_description (18.52s) === CONT TestAccKafkaConnectWorkerConfiguration_basic --- PASS: TestAccKafkaConnectWorkerConfigurationDataSource_basic (22.36s) --- PASS: TestAccKafkaConnectWorkerConfiguration_basic (16.57s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 39.258s
…ars' and 'TestAccKafkaConnectConnector_update'. Acceptance test output: % AWS_DEFAULT_REGION=us-east-1 make testacc TESTS=TestAccKafkaConnectConnector PKG=kafkaconnect ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectConnector' -timeout 180m === RUN TestAccKafkaConnectConnectorDataSource_basic === PAUSE TestAccKafkaConnectConnectorDataSource_basic === RUN TestAccKafkaConnectConnector_basic === PAUSE TestAccKafkaConnectConnector_basic === RUN TestAccKafkaConnectConnector_disappears === PAUSE TestAccKafkaConnectConnector_disappears === RUN TestAccKafkaConnectConnector_update === PAUSE TestAccKafkaConnectConnector_update === CONT TestAccKafkaConnectConnectorDataSource_basic === CONT TestAccKafkaConnectConnector_disappears --- PASS: TestAccKafkaConnectConnector_disappears (2211.69s) === CONT TestAccKafkaConnectConnector_basic --- PASS: TestAccKafkaConnectConnectorDataSource_basic (2211.72s) === CONT TestAccKafkaConnectConnector_update --- PASS: TestAccKafkaConnectConnector_update (2762.06s) --- PASS: TestAccKafkaConnectConnector_basic (2541.67s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 4760.897s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% AWS_DEFAULT_REGION=us-east-1 make testacc TESTS=TestAccKafkaConnectConnector PKG=kafkaconnect ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 2 -run='TestAccKafkaConnectConnector' -timeout 180m
=== RUN TestAccKafkaConnectConnectorDataSource_basic
=== PAUSE TestAccKafkaConnectConnectorDataSource_basic
=== RUN TestAccKafkaConnectConnector_basic
=== PAUSE TestAccKafkaConnectConnector_basic
=== RUN TestAccKafkaConnectConnector_disappears
=== PAUSE TestAccKafkaConnectConnector_disappears
=== RUN TestAccKafkaConnectConnector_update
=== PAUSE TestAccKafkaConnectConnector_update
=== CONT TestAccKafkaConnectConnectorDataSource_basic
=== CONT TestAccKafkaConnectConnector_disappears
--- PASS: TestAccKafkaConnectConnector_disappears (2211.69s)
=== CONT TestAccKafkaConnectConnector_basic
--- PASS: TestAccKafkaConnectConnectorDataSource_basic (2211.72s)
=== CONT TestAccKafkaConnectConnector_update
--- PASS: TestAccKafkaConnectConnector_update (2762.06s)
--- PASS: TestAccKafkaConnectConnector_basic (2541.67s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect 4760.897s
@gungoren Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20942.
Relates #21073.
Similar #22919.
Closes #22682.
Output from acceptance testing: