Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_gamelift_game_server_group #23606

Merged
merged 20 commits into from
Mar 14, 2022
Merged

r/aws_gamelift_game_server_group #23606

merged 20 commits into from
Mar 14, 2022

Conversation

ajjohnston
Copy link
Contributor

@ajjohnston ajjohnston commented Mar 10, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18002

Supersedes #18003, taking this across the finish line.

Output from acceptance testing:

$ make testacc TESTS=TestAccGameliftGameServerGroup PKG=gamelift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run='TestAccGameliftGameServerGroup'  -timeout 180m
=== RUN   TestAccGameliftGameServerGroup_basic
=== PAUSE TestAccGameliftGameServerGroup_basic
=== RUN   TestAccGameliftGameServerGroup_AutoScalingPolicy
=== PAUSE TestAccGameliftGameServerGroup_AutoScalingPolicy
=== RUN   TestAccGameliftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup
=== PAUSE TestAccGameliftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup
=== RUN   TestAccGameliftGameServerGroup_BalancingStrategy
=== PAUSE TestAccGameliftGameServerGroup_BalancingStrategy
=== RUN   TestAccGameliftGameServerGroup_GameServerGroupName
=== PAUSE TestAccGameliftGameServerGroup_GameServerGroupName
=== RUN   TestAccGameliftGameServerGroup_InstanceDefinition
=== PAUSE TestAccGameliftGameServerGroup_InstanceDefinition
=== RUN   TestAccGameliftGameServerGroup_InstanceDefinition_WeightedCapacity
=== PAUSE TestAccGameliftGameServerGroup_InstanceDefinition_WeightedCapacity
=== RUN   TestAccGameliftGameServerGroup_LaunchTemplate_Id
=== PAUSE TestAccGameliftGameServerGroup_LaunchTemplate_Id
=== RUN   TestAccGameliftGameServerGroup_LaunchTemplate_Name
=== PAUSE TestAccGameliftGameServerGroup_LaunchTemplate_Name
=== RUN   TestAccGameliftGameServerGroup_LaunchTemplate_Version
=== PAUSE TestAccGameliftGameServerGroup_LaunchTemplate_Version
=== RUN   TestAccGameliftGameServerGroup_GameServerProtectionPolicy
=== PAUSE TestAccGameliftGameServerGroup_GameServerProtectionPolicy
=== RUN   TestAccGameliftGameServerGroup_MaxSize
=== PAUSE TestAccGameliftGameServerGroup_MaxSize
=== RUN   TestAccGameliftGameServerGroup_MinSize
=== PAUSE TestAccGameliftGameServerGroup_MinSize
=== RUN   TestAccGameliftGameServerGroup_RoleArn
=== PAUSE TestAccGameliftGameServerGroup_RoleArn
=== RUN   TestAccGameliftGameServerGroup_VpcSubnets
=== PAUSE TestAccGameliftGameServerGroup_VpcSubnets
=== CONT  TestAccGameliftGameServerGroup_basic
=== CONT  TestAccGameliftGameServerGroup_LaunchTemplate_Name
=== CONT  TestAccGameliftGameServerGroup_InstanceDefinition
=== CONT  TestAccGameliftGameServerGroup_MinSize
=== CONT  TestAccGameliftGameServerGroup_RoleArn
=== CONT  TestAccGameliftGameServerGroup_AutoScalingPolicy
=== CONT  TestAccGameliftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup
=== CONT  TestAccGameliftGameServerGroup_GameServerGroupName
=== CONT  TestAccGameliftGameServerGroup_LaunchTemplate_Id
=== CONT  TestAccGameliftGameServerGroup_InstanceDefinition_WeightedCapacity
=== CONT  TestAccGameliftGameServerGroup_MaxSize
=== CONT  TestAccGameliftGameServerGroup_GameServerProtectionPolicy
=== CONT  TestAccGameliftGameServerGroup_VpcSubnets
=== CONT  TestAccGameliftGameServerGroup_LaunchTemplate_Version
=== CONT  TestAccGameliftGameServerGroup_BalancingStrategy
--- PASS: TestAccGameliftGameServerGroup_LaunchTemplate_Name (161.70s)
--- PASS: TestAccGameliftGameServerGroup_AutoScalingPolicy (208.04s)
--- PASS: TestAccGameliftGameServerGroup_basic (208.13s)
--- PASS: TestAccGameliftGameServerGroup_BalancingStrategy (252.71s)
--- PASS: TestAccGameliftGameServerGroup_InstanceDefinition_WeightedCapacity (252.79s)
--- PASS: TestAccGameliftGameServerGroup_GameServerProtectionPolicy (254.16s)
--- PASS: TestAccGameliftGameServerGroup_RoleArn (254.56s)
--- PASS: TestAccGameliftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup (275.76s)
--- PASS: TestAccGameliftGameServerGroup_InstanceDefinition (287.94s)
--- PASS: TestAccGameliftGameServerGroup_LaunchTemplate_Id (314.77s)
--- PASS: TestAccGameliftGameServerGroup_LaunchTemplate_Version (335.46s)
--- PASS: TestAccGameliftGameServerGroup_GameServerGroupName (349.02s)
--- PASS: TestAccGameliftGameServerGroup_MaxSize (356.25s)
--- PASS: TestAccGameliftGameServerGroup_MinSize (403.62s)
--- PASS: TestAccGameliftGameServerGroup_VpcSubnets (428.04s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   428.102s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/gamelift Issues and PRs that pertain to the gamelift service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Mar 10, 2022
github-actions[bot]
github-actions bot reviewed Mar 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ajjohnston 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 14, 2022
@ewbankkit ewbankkit mentioned this pull request Mar 14, 2022
Closed
ewbankkit
ewbankkit approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccGameliftGameServerGroup_ PKG=gamelift ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/gamelift/... -v -count 1 -parallel 2 -run='TestAccGameliftGameServerGroup_'  -timeout 180m
=== RUN   TestAccGameliftGameServerGroup_basic
=== PAUSE TestAccGameliftGameServerGroup_basic
=== RUN   TestAccGameliftGameServerGroup_AutoScalingPolicy
=== PAUSE TestAccGameliftGameServerGroup_AutoScalingPolicy
=== RUN   TestAccGameliftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup
=== PAUSE TestAccGameliftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup
=== RUN   TestAccGameliftGameServerGroup_BalancingStrategy
=== PAUSE TestAccGameliftGameServerGroup_BalancingStrategy
=== RUN   TestAccGameliftGameServerGroup_GameServerGroupName
=== PAUSE TestAccGameliftGameServerGroup_GameServerGroupName
=== RUN   TestAccGameliftGameServerGroup_InstanceDefinition
=== PAUSE TestAccGameliftGameServerGroup_InstanceDefinition
=== RUN   TestAccGameliftGameServerGroup_InstanceDefinition_WeightedCapacity
=== PAUSE TestAccGameliftGameServerGroup_InstanceDefinition_WeightedCapacity
=== RUN   TestAccGameliftGameServerGroup_LaunchTemplate_Id
=== PAUSE TestAccGameliftGameServerGroup_LaunchTemplate_Id
=== RUN   TestAccGameliftGameServerGroup_LaunchTemplate_Name
=== PAUSE TestAccGameliftGameServerGroup_LaunchTemplate_Name
=== RUN   TestAccGameliftGameServerGroup_LaunchTemplate_Version
=== PAUSE TestAccGameliftGameServerGroup_LaunchTemplate_Version
=== RUN   TestAccGameliftGameServerGroup_GameServerProtectionPolicy
=== PAUSE TestAccGameliftGameServerGroup_GameServerProtectionPolicy
=== RUN   TestAccGameliftGameServerGroup_MaxSize
=== PAUSE TestAccGameliftGameServerGroup_MaxSize
=== RUN   TestAccGameliftGameServerGroup_MinSize
=== PAUSE TestAccGameliftGameServerGroup_MinSize
=== RUN   TestAccGameliftGameServerGroup_RoleArn
=== PAUSE TestAccGameliftGameServerGroup_RoleArn
=== RUN   TestAccGameliftGameServerGroup_VpcSubnets
=== PAUSE TestAccGameliftGameServerGroup_VpcSubnets
=== CONT  TestAccGameliftGameServerGroup_basic
=== CONT  TestAccGameliftGameServerGroup_LaunchTemplate_Name
--- PASS: TestAccGameliftGameServerGroup_LaunchTemplate_Name (233.30s)
=== CONT  TestAccGameliftGameServerGroup_MinSize
--- PASS: TestAccGameliftGameServerGroup_basic (244.39s)
=== CONT  TestAccGameliftGameServerGroup_VpcSubnets
--- PASS: TestAccGameliftGameServerGroup_VpcSubnets (466.83s)
=== CONT  TestAccGameliftGameServerGroup_RoleArn
--- PASS: TestAccGameliftGameServerGroup_MinSize (485.83s)
=== CONT  TestAccGameliftGameServerGroup_GameServerProtectionPolicy
--- PASS: TestAccGameliftGameServerGroup_GameServerProtectionPolicy (200.52s)
=== CONT  TestAccGameliftGameServerGroup_MaxSize
--- PASS: TestAccGameliftGameServerGroup_RoleArn (215.23s)
=== CONT  TestAccGameliftGameServerGroup_LaunchTemplate_Version
--- PASS: TestAccGameliftGameServerGroup_LaunchTemplate_Version (191.36s)
=== CONT  TestAccGameliftGameServerGroup_GameServerGroupName
--- PASS: TestAccGameliftGameServerGroup_MaxSize (338.40s)
=== CONT  TestAccGameliftGameServerGroup_LaunchTemplate_Id
--- PASS: TestAccGameliftGameServerGroup_LaunchTemplate_Id (186.63s)
=== CONT  TestAccGameliftGameServerGroup_InstanceDefinition_WeightedCapacity
--- PASS: TestAccGameliftGameServerGroup_GameServerGroupName (409.97s)
=== CONT  TestAccGameliftGameServerGroup_InstanceDefinition
--- PASS: TestAccGameliftGameServerGroup_InstanceDefinition_WeightedCapacity (201.71s)
=== CONT  TestAccGameliftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup
--- PASS: TestAccGameliftGameServerGroup_InstanceDefinition (279.57s)
=== CONT  TestAccGameliftGameServerGroup_BalancingStrategy
--- PASS: TestAccGameliftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup (224.48s)
=== CONT  TestAccGameliftGameServerGroup_AutoScalingPolicy
--- PASS: TestAccGameliftGameServerGroup_BalancingStrategy (259.16s)
--- PASS: TestAccGameliftGameServerGroup_AutoScalingPolicy (216.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/gamelift	2090.732s

@ewbankkit
Copy link
Contributor

@ajjohnston Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 49b9dd1 into hashicorp:main Mar 14, 2022
@github-actions github-actions bot added this to the v4.6.0 milestone Mar 14, 2022
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jobrienTC jobrienTC jobrienTC approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/gamelift Issues and PRs that pertain to the gamelift service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.6.0
Development

Successfully merging this pull request may close these issues.

Support for Gamelift Game Server Group
4 participants
@ajjohnston @ewbankkit @jobrienTC @lystor