Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket_versioning: support disabled versioning i.e. unversioned buckets #23723

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 17, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23718

Output from acceptance testing:

--- PASS: TestAccS3BucketVersioning_disappears (27.36s)
--- PASS: TestAccS3BucketVersioning_Status_disabled (28.38s)
--- PASS: TestAccS3BucketVersioning_basic (31.13s)
--- PASS: TestAccS3BucketVersioning_MFADelete (31.16s)
--- PASS: TestAccS3BucketVersioning_Status_suspendedToDisabled (32.19s)
--- PASS: TestAccS3BucketVersioning_Status_enabledToDisabled (32.51s)
--- PASS: TestAccS3BucketVersioning_Status_disabledToSuspended (47.90s)
--- PASS: TestAccS3BucketVersioning_Status_disabledToEnabled (50.36s)
--- PASS: TestAccS3BucketVersioning_update (69.02s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 17, 2022
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Mar 17, 2022
anGie44 added a commit that referenced this pull request Mar 17, 2022
@anGie44 anGie44 force-pushed the b-s3-bucket-versioning-disabled branch from 2b12b90 to 4651686 Compare March 17, 2022 05:47
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccS3BucketVersioning_ PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run='TestAccS3BucketVersioning_'  -timeout 180m
=== RUN   TestAccS3BucketVersioning_basic
=== PAUSE TestAccS3BucketVersioning_basic
=== RUN   TestAccS3BucketVersioning_disappears
=== PAUSE TestAccS3BucketVersioning_disappears
=== RUN   TestAccS3BucketVersioning_update
=== PAUSE TestAccS3BucketVersioning_update
=== RUN   TestAccS3BucketVersioning_MFADelete
=== PAUSE TestAccS3BucketVersioning_MFADelete
=== RUN   TestAccS3BucketVersioning_Status_disabled
=== PAUSE TestAccS3BucketVersioning_Status_disabled
=== RUN   TestAccS3BucketVersioning_Status_disabledToEnabled
=== PAUSE TestAccS3BucketVersioning_Status_disabledToEnabled
=== RUN   TestAccS3BucketVersioning_Status_disabledToSuspended
=== PAUSE TestAccS3BucketVersioning_Status_disabledToSuspended
=== RUN   TestAccS3BucketVersioning_Status_enabledToDisabled
=== PAUSE TestAccS3BucketVersioning_Status_enabledToDisabled
=== RUN   TestAccS3BucketVersioning_Status_suspendedToDisabled
=== PAUSE TestAccS3BucketVersioning_Status_suspendedToDisabled
=== CONT  TestAccS3BucketVersioning_basic
=== CONT  TestAccS3BucketVersioning_Status_disabledToEnabled
=== CONT  TestAccS3BucketVersioning_MFADelete
--- PASS: TestAccS3BucketVersioning_MFADelete (28.23s)
=== CONT  TestAccS3BucketVersioning_update
--- PASS: TestAccS3BucketVersioning_basic (28.38s)
=== CONT  TestAccS3BucketVersioning_disappears
--- PASS: TestAccS3BucketVersioning_Status_disabledToEnabled (49.97s)
=== CONT  TestAccS3BucketVersioning_Status_enabledToDisabled
--- PASS: TestAccS3BucketVersioning_disappears (23.42s)
=== CONT  TestAccS3BucketVersioning_Status_suspendedToDisabled
--- PASS: TestAccS3BucketVersioning_Status_enabledToDisabled (28.37s)
=== CONT  TestAccS3BucketVersioning_Status_disabled
--- PASS: TestAccS3BucketVersioning_Status_suspendedToDisabled (28.09s)
=== CONT  TestAccS3BucketVersioning_Status_disabledToSuspended
--- PASS: TestAccS3BucketVersioning_update (69.79s)
--- PASS: TestAccS3BucketVersioning_Status_disabled (29.13s)
--- PASS: TestAccS3BucketVersioning_Status_disabledToSuspended (61.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	144.991s

@anGie44 anGie44 added this to the v4.6.0 milestone Mar 17, 2022
@anGie44 anGie44 merged commit 8ea87de into main Mar 17, 2022
@anGie44 anGie44 deleted the b-s3-bucket-versioning-disabled branch March 17, 2022 14:45
anGie44 added a commit that referenced this pull request Mar 17, 2022
anGie44 added a commit that referenced this pull request Mar 17, 2022
anGie44 added a commit that referenced this pull request Mar 17, 2022
r/s3_bucket_versioning: backport #23723; support management of resource with disabled versioning
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

obourdon pushed a commit to obourdon/terraform-provider-aws that referenced this pull request Mar 28, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_s3_bucket_versioning cannot disable versioning
2 participants