Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/athena_database - add acl_configuration and expected_bucket_owner args #23745

Merged
merged 21 commits into from
Mar 18, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Mar 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12374.

Output from acceptance testing:

$ make testacc TESTS=TestAccAthenaDatabase_ PKG=athena

--- PASS: TestAccAthenaDatabase_nameCantHaveUppercase (5.16s)
--- PASS: TestAccAthenaDatabase_disppears (52.44s)
--- PASS: TestAccAthenaDatabase_acl (54.69s)
--- PASS: TestAccAthenaDatabase_nameStartsWithUnderscore (55.01s)
--- PASS: TestAccAthenaDatabase_basic (55.65s)
--- PASS: TestAccAthenaDatabase_encryption (57.44s)
--- PASS: TestAccAthenaDatabase_forceDestroyAlwaysSucceeds (57.71s)
--- PASS: TestAccAthenaDatabase_destroyFailsIfTablesExist (68.67s)

@github-actions github-actions bot added service/athena Issues and PRs that pertain to the athena service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Mar 18, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 18, 2022
@DrFaust92 DrFaust92 marked this pull request as draft March 18, 2022 09:27
@DrFaust92 DrFaust92 marked this pull request as ready for review March 18, 2022 10:01
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. and removed sweeper Pertains to changes to or issues with the sweeper. labels Mar 18, 2022
@DrFaust92 DrFaust92 added the sweeper Pertains to changes to or issues with the sweeper. label Mar 18, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAthenaDatabase_ PKG=athena ACCTEST_PARALLELISM=2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 2 -run='TestAccAthenaDatabase_'  -timeout 180m
=== RUN   TestAccAthenaDatabase_basic
=== PAUSE TestAccAthenaDatabase_basic
=== RUN   TestAccAthenaDatabase_acl
=== PAUSE TestAccAthenaDatabase_acl
=== RUN   TestAccAthenaDatabase_encryption
=== PAUSE TestAccAthenaDatabase_encryption
=== RUN   TestAccAthenaDatabase_nameStartsWithUnderscore
=== PAUSE TestAccAthenaDatabase_nameStartsWithUnderscore
=== RUN   TestAccAthenaDatabase_nameCantHaveUppercase
=== PAUSE TestAccAthenaDatabase_nameCantHaveUppercase
=== RUN   TestAccAthenaDatabase_destroyFailsIfTablesExist
=== PAUSE TestAccAthenaDatabase_destroyFailsIfTablesExist
=== RUN   TestAccAthenaDatabase_forceDestroyAlwaysSucceeds
=== PAUSE TestAccAthenaDatabase_forceDestroyAlwaysSucceeds
=== RUN   TestAccAthenaDatabase_description
=== PAUSE TestAccAthenaDatabase_description
=== RUN   TestAccAthenaDatabase_unescaped_description
=== PAUSE TestAccAthenaDatabase_unescaped_description
=== RUN   TestAccAthenaDatabase_disppears
=== PAUSE TestAccAthenaDatabase_disppears
=== CONT  TestAccAthenaDatabase_basic
=== CONT  TestAccAthenaDatabase_destroyFailsIfTablesExist
--- PASS: TestAccAthenaDatabase_basic (33.15s)
=== CONT  TestAccAthenaDatabase_nameStartsWithUnderscore
--- PASS: TestAccAthenaDatabase_destroyFailsIfTablesExist (43.26s)
=== CONT  TestAccAthenaDatabase_nameCantHaveUppercase
--- PASS: TestAccAthenaDatabase_nameCantHaveUppercase (0.73s)
=== CONT  TestAccAthenaDatabase_unescaped_description
--- PASS: TestAccAthenaDatabase_nameStartsWithUnderscore (27.06s)
=== CONT  TestAccAthenaDatabase_disppears
--- PASS: TestAccAthenaDatabase_unescaped_description (26.08s)
=== CONT  TestAccAthenaDatabase_encryption
--- PASS: TestAccAthenaDatabase_disppears (24.40s)
=== CONT  TestAccAthenaDatabase_acl
--- PASS: TestAccAthenaDatabase_encryption (28.60s)
=== CONT  TestAccAthenaDatabase_description
--- PASS: TestAccAthenaDatabase_acl (29.92s)
=== CONT  TestAccAthenaDatabase_forceDestroyAlwaysSucceeds
--- PASS: TestAccAthenaDatabase_description (28.64s)
--- PASS: TestAccAthenaDatabase_forceDestroyAlwaysSucceeds (29.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	147.444s

@ewbankkit
Copy link
Contributor

@DrFaust92 @miyajan @drexler Thanks for the contributions 🎉 👏.

@ewbankkit ewbankkit merged commit 008a2d8 into hashicorp:main Mar 18, 2022
@github-actions github-actions bot added this to the v4.6.0 milestone Mar 18, 2022
@DrFaust92 DrFaust92 deleted the athena-database branch March 18, 2022 16:33
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/athena Issues and PRs that pertain to the athena service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "description" or "comment" support for aws_athena_database
4 participants