Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/athena_workgroup - add acl_configuration and expected_bucket_owner args #23748

Merged
merged 8 commits into from
Mar 18, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Mar 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccAthenaWorkGroup_ PKG=athena
--- PASS: TestAccAthenaWorkGroup_disappears (28.99s)
--- PASS: TestAccAthenaWorkGroup_aclConfig (35.61s)
--- PASS: TestAccAthenaWorkGroup_basic (38.28s)
--- PASS: TestAccAthenaWorkGroup_ResultEncryption_sseS3 (38.35s)
--- PASS: TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery (58.18s)
--- PASS: TestAccAthenaWorkGroup_forceDestroy (58.39s)
--- PASS: TestAccAthenaWorkGroup_description (60.73s)
--- PASS: TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled (61.05s)
--- PASS: TestAccAthenaWorkGroup_enforceWorkGroup (61.32s)
--- PASS: TestAccAthenaWorkGroup_requesterPaysEnabled (61.37s)
--- PASS: TestAccAthenaWorkGroup_ResultEncryption_kms (66.23s)
--- PASS: TestAccAthenaWorkGroup_tags (81.81s)
--- PASS: TestAccAthenaWorkGroup_configurationEngineVersion (82.46s)
--- PASS: TestAccAthenaWorkGroup_state (82.72s)
--- PASS: TestAccAthenaWorkGroup_Result_outputLocation (85.23s)
--- PASS: TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy (85.48s)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/athena Issues and PRs that pertain to the athena service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/athena Issues and PRs that pertain to the athena service. labels Mar 18, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/athena Issues and PRs that pertain to the athena service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/athena Issues and PRs that pertain to the athena service. labels Mar 18, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/athena Issues and PRs that pertain to the athena service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 18, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review March 18, 2022 17:00
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAthenaWorkGroup_ PKG=athena ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 3 -run='TestAccAthenaWorkGroup_'  -timeout 180m
=== RUN   TestAccAthenaWorkGroup_basic
=== PAUSE TestAccAthenaWorkGroup_basic
=== RUN   TestAccAthenaWorkGroup_aclConfig
=== PAUSE TestAccAthenaWorkGroup_aclConfig
=== RUN   TestAccAthenaWorkGroup_disappears
=== PAUSE TestAccAthenaWorkGroup_disappears
=== RUN   TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery
=== PAUSE TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery
=== RUN   TestAccAthenaWorkGroup_enforceWorkGroup
=== PAUSE TestAccAthenaWorkGroup_enforceWorkGroup
=== RUN   TestAccAthenaWorkGroup_configurationEngineVersion
=== PAUSE TestAccAthenaWorkGroup_configurationEngineVersion
=== RUN   TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled
=== PAUSE TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled
=== RUN   TestAccAthenaWorkGroup_ResultEncryption_sseS3
=== PAUSE TestAccAthenaWorkGroup_ResultEncryption_sseS3
=== RUN   TestAccAthenaWorkGroup_ResultEncryption_kms
=== PAUSE TestAccAthenaWorkGroup_ResultEncryption_kms
=== RUN   TestAccAthenaWorkGroup_Result_outputLocation
=== PAUSE TestAccAthenaWorkGroup_Result_outputLocation
=== RUN   TestAccAthenaWorkGroup_requesterPaysEnabled
=== PAUSE TestAccAthenaWorkGroup_requesterPaysEnabled
=== RUN   TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy
=== PAUSE TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy
=== RUN   TestAccAthenaWorkGroup_description
=== PAUSE TestAccAthenaWorkGroup_description
=== RUN   TestAccAthenaWorkGroup_state
=== PAUSE TestAccAthenaWorkGroup_state
=== RUN   TestAccAthenaWorkGroup_forceDestroy
=== PAUSE TestAccAthenaWorkGroup_forceDestroy
=== RUN   TestAccAthenaWorkGroup_tags
=== PAUSE TestAccAthenaWorkGroup_tags
=== CONT  TestAccAthenaWorkGroup_tags
=== CONT  TestAccAthenaWorkGroup_basic
=== CONT  TestAccAthenaWorkGroup_forceDestroy
--- PASS: TestAccAthenaWorkGroup_basic (21.27s)
=== CONT  TestAccAthenaWorkGroup_state
--- PASS: TestAccAthenaWorkGroup_forceDestroy (35.61s)
=== CONT  TestAccAthenaWorkGroup_description
--- PASS: TestAccAthenaWorkGroup_tags (50.97s)
=== CONT  TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy
--- PASS: TestAccAthenaWorkGroup_description (35.80s)
=== CONT  TestAccAthenaWorkGroup_requesterPaysEnabled
--- PASS: TestAccAthenaWorkGroup_state (50.24s)
=== CONT  TestAccAthenaWorkGroup_Result_outputLocation
--- PASS: TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy (46.66s)
=== CONT  TestAccAthenaWorkGroup_ResultEncryption_kms
--- PASS: TestAccAthenaWorkGroup_requesterPaysEnabled (33.01s)
=== CONT  TestAccAthenaWorkGroup_ResultEncryption_sseS3
--- PASS: TestAccAthenaWorkGroup_Result_outputLocation (46.09s)
=== CONT  TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery
--- PASS: TestAccAthenaWorkGroup_ResultEncryption_sseS3 (19.93s)
=== CONT  TestAccAthenaWorkGroup_disappears
--- PASS: TestAccAthenaWorkGroup_ResultEncryption_kms (36.46s)
=== CONT  TestAccAthenaWorkGroup_aclConfig
--- PASS: TestAccAthenaWorkGroup_disappears (12.71s)
=== CONT  TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled
--- PASS: TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery (31.44s)
=== CONT  TestAccAthenaWorkGroup_configurationEngineVersion
--- PASS: TestAccAthenaWorkGroup_aclConfig (17.72s)
=== CONT  TestAccAthenaWorkGroup_enforceWorkGroup
--- PASS: TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled (30.27s)
--- PASS: TestAccAthenaWorkGroup_enforceWorkGroup (29.92s)
--- PASS: TestAccAthenaWorkGroup_configurationEngineVersion (42.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	197.864s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 768612b into hashicorp:main Mar 18, 2022
@github-actions github-actions bot added this to the v4.7.0 milestone Mar 18, 2022
@DrFaust92 DrFaust92 deleted the athena-workgroup branch March 18, 2022 20:24
@github-actions
Copy link

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/athena Issues and PRs that pertain to the athena service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants