-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/apigateway_stage - add canary_settings
argument
#23754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAPIGatewayStage_ PKG=apigateway ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 3 -run='TestAccAPIGatewayStage_' -timeout 180m
=== RUN TestAccAPIGatewayStage_basic
=== PAUSE TestAccAPIGatewayStage_basic
=== RUN TestAccAPIGatewayStage_cache
=== PAUSE TestAccAPIGatewayStage_cache
=== RUN TestAccAPIGatewayStage_cache_size_cache_disabled
=== PAUSE TestAccAPIGatewayStage_cache_size_cache_disabled
=== RUN TestAccAPIGatewayStage_Disappears_referencingDeployment
=== PAUSE TestAccAPIGatewayStage_Disappears_referencingDeployment
=== RUN TestAccAPIGatewayStage_tags
=== PAUSE TestAccAPIGatewayStage_tags
=== RUN TestAccAPIGatewayStage_disappears
=== PAUSE TestAccAPIGatewayStage_disappears
=== RUN TestAccAPIGatewayStage_disappears_restApi
=== PAUSE TestAccAPIGatewayStage_disappears_restApi
=== RUN TestAccAPIGatewayStage_accessLogSettings
=== PAUSE TestAccAPIGatewayStage_accessLogSettings
=== RUN TestAccAPIGatewayStage_AccessLogSettings_kinesis
=== PAUSE TestAccAPIGatewayStage_AccessLogSettings_kinesis
=== RUN TestAccAPIGatewayStage_waf
=== PAUSE TestAccAPIGatewayStage_waf
=== RUN TestAccAPIGatewayStage_canarySettings
=== PAUSE TestAccAPIGatewayStage_canarySettings
=== CONT TestAccAPIGatewayStage_basic
=== CONT TestAccAPIGatewayStage_disappears_restApi
=== CONT TestAccAPIGatewayStage_Disappears_referencingDeployment
--- PASS: TestAccAPIGatewayStage_disappears_restApi (41.32s)
=== CONT TestAccAPIGatewayStage_disappears
--- PASS: TestAccAPIGatewayStage_basic (69.14s)
=== CONT TestAccAPIGatewayStage_tags
--- PASS: TestAccAPIGatewayStage_Disappears_referencingDeployment (103.72s)
=== CONT TestAccAPIGatewayStage_waf
--- PASS: TestAccAPIGatewayStage_tags (56.94s)
=== CONT TestAccAPIGatewayStage_canarySettings
--- PASS: TestAccAPIGatewayStage_disappears (121.80s)
=== CONT TestAccAPIGatewayStage_cache_size_cache_disabled
--- PASS: TestAccAPIGatewayStage_canarySettings (71.30s)
=== CONT TestAccAPIGatewayStage_cache
=== CONT TestAccAPIGatewayStage_waf
stage_test.go:445: Step 1/3 error: Error running apply: exit status 1
Error: Error creating WAF Regional Web ACL association: WAFUnavailableEntityException: An entity is unavailable for modification or display. Please retry.
with aws_wafregional_web_acl_association.test,
on terraform_plugin_test.tf line 69, in resource "aws_wafregional_web_acl_association" "test":
69: resource "aws_wafregional_web_acl_association" "test" {
--- FAIL: TestAccAPIGatewayStage_waf (131.37s)
=== CONT TestAccAPIGatewayStage_AccessLogSettings_kinesis
--- PASS: TestAccAPIGatewayStage_AccessLogSettings_kinesis (165.29s)
=== CONT TestAccAPIGatewayStage_accessLogSettings
--- PASS: TestAccAPIGatewayStage_cache_size_cache_disabled (275.42s)
--- PASS: TestAccAPIGatewayStage_accessLogSettings (66.76s)
--- PASS: TestAccAPIGatewayStage_cache (391.49s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 592.799s
FAIL
make: *** [testacc] Error 1
Failure is unrelated to this change.
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #2727
Superseds #10474
Output from acceptance testing:
Thanks @GiPPe for the heavy lifting, i made some changes and adjusted to the current provider struct.