Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_cognito_user_in_group - new resource #23765

Merged
merged 10 commits into from
Mar 21, 2022
Merged

r/aws_cognito_user_in_group - new resource #23765

merged 10 commits into from
Mar 21, 2022

Conversation

kamilturek
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23400.

Output from acceptance testing:

$ make testacc PKG=cognitoidp TESTS="TestAccCognitoUserInGroup_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoUserInGroup_'  -timeout 180m
=== RUN   TestAccCognitoUserInGroup_basic
=== PAUSE TestAccCognitoUserInGroup_basic
=== RUN   TestAccCognitoUserInGroup_disappears
=== PAUSE TestAccCognitoUserInGroup_disappears
=== CONT  TestAccCognitoUserInGroup_basic
=== CONT  TestAccCognitoUserInGroup_disappears
--- PASS: TestAccCognitoUserInGroup_disappears (24.67s)
--- PASS: TestAccCognitoUserInGroup_basic (24.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 26.539s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cognitoidentityprovider tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 19, 2022
@kamilturek kamilturek marked this pull request as ready for review March 19, 2022 19:11
@kamilturek
Copy link
Collaborator Author

I guess we don't need a sweeper for it as the sweepers for users & groups should do the job.

@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 21, 2022
ewbankkit
ewbankkit approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCognitoUserInGroup_ PKG=cognitoidp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoUserInGroup_'  -timeout 180m
=== RUN   TestAccCognitoUserInGroup_basic
=== PAUSE TestAccCognitoUserInGroup_basic
=== RUN   TestAccCognitoUserInGroup_disappears
=== PAUSE TestAccCognitoUserInGroup_disappears
=== CONT  TestAccCognitoUserInGroup_basic
=== CONT  TestAccCognitoUserInGroup_disappears
--- PASS: TestAccCognitoUserInGroup_disappears (17.72s)
--- PASS: TestAccCognitoUserInGroup_basic (17.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	21.625s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c52b3aa into hashicorp:main Mar 21, 2022
@github-actions github-actions bot added this to the v4.7.0 milestone Mar 21, 2022
@github-actions
Copy link

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.

Add a way to assign a cognito user to a group
2 participants
@kamilturek @ewbankkit