Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket: make acl and grant configurable #23798

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 22, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23106
Relates #23758

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccS3Bucket_' PKG=s3 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 5  -run=TestAccS3Bucket_ -timeout 180m
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_Basic_emptyString
=== PAUSE TestAccS3Bucket_Basic_emptyString
=== RUN   TestAccS3Bucket_Basic_generatedName
=== PAUSE TestAccS3Bucket_Basic_generatedName
=== RUN   TestAccS3Bucket_Basic_namePrefix
=== PAUSE TestAccS3Bucket_Basic_namePrefix
=== RUN   TestAccS3Bucket_Basic_forceDestroy
=== PAUSE TestAccS3Bucket_Basic_forceDestroy
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== RUN   TestAccS3Bucket_disappears
=== PAUSE TestAccS3Bucket_disappears
=== RUN   TestAccS3Bucket_Tags_basic
=== PAUSE TestAccS3Bucket_Tags_basic
=== RUN   TestAccS3Bucket_Tags_withNoSystemTags
=== PAUSE TestAccS3Bucket_Tags_withNoSystemTags
=== RUN   TestAccS3Bucket_Tags_withSystemTags
=== PAUSE TestAccS3Bucket_Tags_withSystemTags
=== RUN   TestAccS3Bucket_Tags_ignoreTags
=== PAUSE TestAccS3Bucket_Tags_ignoreTags
=== RUN   TestAccS3Bucket_Manage_objectLock
=== PAUSE TestAccS3Bucket_Manage_objectLock
=== RUN   TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
=== PAUSE TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
=== RUN   TestAccS3Bucket_Manage_objectLock_migrate
=== PAUSE TestAccS3Bucket_Manage_objectLock_migrate
=== RUN   TestAccS3Bucket_Manage_objectLockWithVersioning
=== PAUSE TestAccS3Bucket_Manage_objectLockWithVersioning
=== RUN   TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
=== PAUSE TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
=== RUN   TestAccS3Bucket_Security_updateACL
=== PAUSE TestAccS3Bucket_Security_updateACL
=== RUN   TestAccS3Bucket_Security_updateGrant
=== PAUSE TestAccS3Bucket_Security_updateGrant
=== RUN   TestAccS3Bucket_Security_aclToGrant
=== PAUSE TestAccS3Bucket_Security_aclToGrant
=== RUN   TestAccS3Bucket_Security_grantToACL
=== PAUSE TestAccS3Bucket_Security_grantToACL
=== CONT  TestAccS3Bucket_Basic_basic
=== CONT  TestAccS3Bucket_Security_updateACL
=== CONT  TestAccS3Bucket_Security_grantToACL
=== CONT  TestAccS3Bucket_Security_updateGrant
=== CONT  TestAccS3Bucket_Security_aclToGrant
--- PASS: TestAccS3Bucket_Basic_basic (21.49s)
=== CONT  TestAccS3Bucket_Tags_withNoSystemTags
--- PASS: TestAccS3Bucket_Security_aclToGrant (35.34s)
=== CONT  TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
--- PASS: TestAccS3Bucket_Security_grantToACL (35.44s)
=== CONT  TestAccS3Bucket_Manage_objectLockWithVersioning
=== CONT  TestAccS3Bucket_Manage_objectLock_migrate
--- PASS: TestAccS3Bucket_Security_updateACL (35.45s)
--- PASS: TestAccS3Bucket_Security_updateGrant (56.05s)
=== CONT  TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (24.45s)
=== CONT  TestAccS3Bucket_Manage_objectLock
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (24.37s)
=== CONT  TestAccS3Bucket_Tags_ignoreTags
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (25.75s)
=== CONT  TestAccS3Bucket_Tags_withSystemTags
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (20.65s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
--- PASS: TestAccS3Bucket_Manage_objectLock (19.19s)
=== CONT  TestAccS3Bucket_Tags_basic
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (67.96s)
=== CONT  TestAccS3Bucket_disappears
--- PASS: TestAccS3Bucket_Tags_ignoreTags (34.95s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (18.55s)
=== CONT  TestAccS3Bucket_Basic_namePrefix
--- PASS: TestAccS3Bucket_Tags_basic (22.96s)
=== CONT  TestAccS3Bucket_Basic_forceDestroy
--- PASS: TestAccS3Bucket_disappears (12.80s)
=== CONT  TestAccS3Bucket_Basic_generatedName
--- PASS: TestAccS3Bucket_Basic_namePrefix (19.62s)
=== CONT  TestAccS3Bucket_Basic_emptyString
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (22.73s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (19.17s)
--- PASS: TestAccS3Bucket_Basic_generatedName (20.35s)
--- PASS: TestAccS3Bucket_Basic_emptyString (19.03s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (114.53s)

--- PASS: TestAccS3BucketAcl_disappears (18.22s)
--- PASS: TestAccS3BucketAcl_basic (25.16s)
--- PASS: TestAccS3BucketAcl_migrate_aclNoChange (38.01s)
--- PASS: TestAccS3BucketAcl_migrate_aclWithChange (38.40s)
--- PASS: TestAccS3BucketAcl_migrate_grantsWithChange (40.61s)
--- PASS: TestAccS3BucketAcl_migrate_grantsNoChange (40.61s)
--- PASS: TestAccS3BucketAcl_updateACL (40.62s)
--- PASS: TestAccS3BucketAcl_grantToACL (40.86s)
--- PASS: TestAccS3BucketAcl_ACLToGrant (42.12s)
--- PASS: TestAccS3BucketAcl_updateGrant (44.25s)

--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (17.33s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (21.65s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (24.26s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (53.38s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (53.39s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (53.40s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (53.47s)

--- PASS: TestAccS3ObjectCopy_basic (21.13s)
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_bucket (21.17s)
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_object (21.84s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 22, 2022
anGie44 added a commit that referenced this pull request Mar 22, 2022
anGie44 added a commit that referenced this pull request Mar 22, 2022
anGie44 added a commit that referenced this pull request Mar 23, 2022
@anGie44 anGie44 marked this pull request as ready for review March 23, 2022 00:30
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 23, 2022
@anGie44 anGie44 marked this pull request as draft March 23, 2022 00:56
@anGie44 anGie44 changed the base branch from main to release/4.x-s3-bucket-changes March 24, 2022 05:37
@anGie44 anGie44 marked this pull request as ready for review March 31, 2022 20:24
@anGie44 anGie44 merged commit 598c64d into release/4.x-s3-bucket-changes Mar 31, 2022
@anGie44 anGie44 deleted the s3-bucket-acl-and-grants branch March 31, 2022 20:38
@github-actions github-actions bot added this to the v4.9.0 milestone Mar 31, 2022
github-actions bot pushed a commit that referenced this pull request Mar 31, 2022
anGie44 added a commit that referenced this pull request Apr 1, 2022
anGie44 pushed a commit that referenced this pull request Apr 1, 2022
anGie44 added a commit that referenced this pull request Apr 1, 2022
anGie44 pushed a commit that referenced this pull request Apr 1, 2022
anGie44 added a commit that referenced this pull request Apr 2, 2022
anGie44 pushed a commit that referenced this pull request Apr 2, 2022
gdavison pushed a commit that referenced this pull request Apr 5, 2022
gdavison pushed a commit that referenced this pull request Apr 5, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant