d/eips - set public_ips for vpc as well as ec2 classic

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23847

Output from acceptance testing:

$ ake testacc TESTS=TestAccEC2EIPsDataSource_vpcDomain PKG=ec2

--- PASS: TestAccEC2EIPsDataSource_vpcDomain (30.42s)

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccEC2EIPsDataSource_ PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run='TestAccEC2EIPsDataSource_'  -timeout 180m
=== RUN   TestAccEC2EIPsDataSource_vpcDomain
=== PAUSE TestAccEC2EIPsDataSource_vpcDomain
=== RUN   TestAccEC2EIPsDataSource_standardDomain
=== PAUSE TestAccEC2EIPsDataSource_standardDomain
=== CONT  TestAccEC2EIPsDataSource_vpcDomain
=== CONT  TestAccEC2EIPsDataSource_standardDomain
--- PASS: TestAccEC2EIPsDataSource_standardDomain (13.94s)
--- PASS: TestAccEC2EIPsDataSource_vpcDomain (19.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	26.420s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.