Support AWS AppFlow: aws_appflow_connector_profile resource

[szemek]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16253

[zhelding]

Hi @szemek. Thank you so much for your work on this! We really appreciate your contribution here -- as well as your past PRs upon which it is based (i.e. #18183 + #19543).

Thank you also for keeping up with my numerous edits and tweaking the docs as necessary; it's been very helpful in closing things out here.

The major edits here revolved around acceptance testing: namely, our inability to reliably perform acceptance tests that rely upon non-AWS resources. As a result, we can only test connector profiles of connector_type = "Redshift".

Limiting ourselves to Redshift: we're able to get some passing acceptance tests!

Other changes mostly focused on adding a couple of missing attributes (i.e. config properties for SAPOData or custom connector profiles) -- and resolving build errors resulting from edits.

Code Notes

Context-Dependent Structs

As with AppFlow flows (#24017), AppFlow connector profiles have certain attributes representing structures with "context-dependent" members. As the underlying types of these structures are undocumented, we are not able to support their use.

Credentials are Write-Only

Credentials set by CreateConnectorProfile are not returned by any AppFlow API operation. Instead, a credentialsArn field is returned. It may be possible to somehow read from the resource to which credentialsArn directs us, but this would require further investigation.

Once we're green on all checks, I'll confirm the acceptance tests are still passing one last time, and then we can get this merged!

[zhelding]

Acceptance tests passing on latest commit 7238c86:

❯ make testacc TESTS=TestAccAppFlowConnectorProfile PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20 -run='TestAccAppFlowConnectorProfile'  -timeout 180m
=== RUN   TestAccAppFlowConnectorProfile_basic
=== PAUSE TestAccAppFlowConnectorProfile_basic
=== RUN   TestAccAppFlowConnectorProfile_update
=== PAUSE TestAccAppFlowConnectorProfile_update
=== RUN   TestAccAppFlowConnectorProfile_disappears
=== PAUSE TestAccAppFlowConnectorProfile_disappears
=== CONT  TestAccAppFlowConnectorProfile_basic
=== CONT  TestAccAppFlowConnectorProfile_disappears
=== CONT  TestAccAppFlowConnectorProfile_update
--- PASS: TestAccAppFlowConnectorProfile_disappears (219.21s)
--- PASS: TestAccAppFlowConnectorProfile_update (257.46s)
--- PASS: TestAccAppFlowConnectorProfile_basic (259.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appflow    260.049s

Merging! 🚀

[github-actions]

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.