-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_memorydb_cluster: new data source #23991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccMemoryDBClusterDataSource_\|TestAccMemoryDBCluster_update_numReplicasPerShard_' PKG=memorydb ACCTEST_TIMEOUT=600m ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 2 -run=TestAccMemoryDBClusterDataSource_\|TestAccMemoryDBCluster_update_numReplicasPerShard_ -timeout 600m
=== RUN TestAccMemoryDBClusterDataSource_basic
=== PAUSE TestAccMemoryDBClusterDataSource_basic
=== RUN TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
=== PAUSE TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
=== RUN TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
=== PAUSE TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
=== CONT TestAccMemoryDBClusterDataSource_basic
=== CONT TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown
--- PASS: TestAccMemoryDBCluster_update_numReplicasPerShard_scaleDown (1493.33s)
=== CONT TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp
--- PASS: TestAccMemoryDBClusterDataSource_basic (1542.34s)
--- PASS: TestAccMemoryDBCluster_update_numReplicasPerShard_scaleUp (1459.47s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 2957.001s
@roberth-k Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #23795
Output from acceptance testing: