Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IoT Authorizer HTTP caching support #23993

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

tmarlok88
Copy link
Contributor

Adds support for HTTP caching on an IoT authorizer.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ AWS_PROFILE=default make testacc TESTARGS='-run=TestAccIoTAuthorizer_basic' PKG_NAME=internal/service/iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20  -run=TestAccIoTAuthorizer_basic -timeout 180m
=== RUN   TestAccIoTAuthorizer_basic
=== PAUSE TestAccIoTAuthorizer_basic
=== CONT  TestAccIoTAuthorizer_basic
--- PASS: TestAccIoTAuthorizer_basic (55.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	55.317s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 1, 2022
@tmarlok88 tmarlok88 changed the title IoT Authorizer HTTP cahcing support IoT Authorizer HTTP caching support Apr 1, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccIoTAuthorizer_ PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run='TestAccIoTAuthorizer_'  -timeout 180m
=== RUN   TestAccIoTAuthorizer_basic
=== PAUSE TestAccIoTAuthorizer_basic
=== RUN   TestAccIoTAuthorizer_disappears
=== PAUSE TestAccIoTAuthorizer_disappears
=== RUN   TestAccIoTAuthorizer_signingDisabled
=== PAUSE TestAccIoTAuthorizer_signingDisabled
=== RUN   TestAccIoTAuthorizer_update
=== PAUSE TestAccIoTAuthorizer_update
=== CONT  TestAccIoTAuthorizer_basic
=== CONT  TestAccIoTAuthorizer_signingDisabled
--- PASS: TestAccIoTAuthorizer_signingDisabled (42.16s)
=== CONT  TestAccIoTAuthorizer_disappears
--- PASS: TestAccIoTAuthorizer_basic (47.45s)
=== CONT  TestAccIoTAuthorizer_update
--- PASS: TestAccIoTAuthorizer_disappears (29.18s)
--- PASS: TestAccIoTAuthorizer_update (42.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	94.099s

@ewbankkit
Copy link
Contributor

@tmarlok88 Thanks for the contribution 🎉 👏.
I renamed the new argument to enable_caching_for_http to match the underlying AWS API field.

@ewbankkit ewbankkit merged commit 9e70f31 into hashicorp:main Apr 1, 2022
@github-actions github-actions bot added this to the v4.9.0 milestone Apr 1, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/iot Issues and PRs that pertain to the iot service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants